Fix/doesnt wait timeout on button reset timeout pressed during subtlealert

[ValeriiMalkov]

Implements/Fixes #631

This PR is ready for review.

Testing Plan

Manual testing

Summary

Added check that the click event was triggered over ResetTimeoutPopUp and over ResetTimeoutButton to the SubleAlertPopUp in click method.

CLA

• I have signed the CLA

[ValeriiMalkov]

Hi @theresalech ! This is a regression issue and ready for Livio team review.

[iCollin]

I think doing something like this might be better than a string compare on multiple class names for the reset timeout popup:

diff --git a/app/view/sdl/SubtleAlertPopUp.js b/app/view/sdl/SubtleAlertPopUp.js
index a0a0314..e47ff69 100644
--- a/app/view/sdl/SubtleAlertPopUp.js
+++ b/app/view/sdl/SubtleAlertPopUp.js
@@ -70,7 +70,8 @@ SDL.SubtleAlertPopUp = Em.ContainerView.create(
                 this.deactivate();
                 SDL.SDLController.onActivateSDLApp({ appID: SDL.SubtleAlertPopUp.appID });
                 SDL.SDLController.onSubtleAlertPressed(SDL.SubtleAlertPopUp.appID);
-            } else{
+            } else if (!document.getElementById('right_view').contains(event.target)
+            && !document.getElementById('ResetTimeoutPopUp').contains(event.target)) {
                 SDL.SubtleAlertPopUp.deactivate();
             }
         },

Also we should exempt the right_view too so that buttons can be pressed while an alert is active.

[ValeriiMalkov]

I think doing something like this might be better than a string compare on multiple class names for the reset timeout popup:

diff --git a/app/view/sdl/SubtleAlertPopUp.js b/app/view/sdl/SubtleAlertPopUp.js
index a0a0314..e47ff69 100644
--- a/app/view/sdl/SubtleAlertPopUp.js
+++ b/app/view/sdl/SubtleAlertPopUp.js
@@ -70,7 +70,8 @@ SDL.SubtleAlertPopUp = Em.ContainerView.create(
                 this.deactivate();
                 SDL.SDLController.onActivateSDLApp({ appID: SDL.SubtleAlertPopUp.appID });
                 SDL.SDLController.onSubtleAlertPressed(SDL.SubtleAlertPopUp.appID);
-            } else{
+            } else if (!document.getElementById('right_view').contains(event.target)
+            && !document.getElementById('ResetTimeoutPopUp').contains(event.target)) {
                 SDL.SubtleAlertPopUp.deactivate();
             }
         },

Also we should exempt the right_view too so that buttons can be pressed while an alert is active.

@iCollin Implemented in commit c2477c3