remove unnecessary MenuList setMode #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobkeeler
requested changes
May 28, 2021
This reverts commit 2d43636.
… call to scrollableMessage
jacobkeeler
approved these changes
Jun 1, 2021
ValeriiMalkov
pushed a commit
to LuxoftSDL/sdl_hmi
that referenced
this pull request
Jul 16, 2021
* remove unnecessary MenuList setMode * Revert "remove unnecessary MenuList setMode" This reverts commit 2d43636. * fix console error with scrollable message change mode and add setMode call to scrollableMessage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements/Fixes #317
This PR is ready for review.
Testing Plan
Reproduction steps from issue, manual tests with display Mode
Summary
Remove unnecessary setMode from MenuList, the childView buttons update by displayMode without this function and setMode can cause a console error when the children are being updated.
CLA