Fixed HMI shows identical navigation buttons for all registered apps #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #578
This PR is ready for review.
Testing Plan
Precondition:
1. SDL and HMI are started
2. Mobile device connected
3. Navigation app1 and navigation app2
4. Mobile app1 is activated
Steps to reproduce:
Nav Buttonson app1 HMI screenNav Buttonson app2 HMI screenSummary
Looks like all application models used a reference to the same instance of the map
NAV_BUTTONSso in case if one navigation app updates its subscriptions, the same changes would be applied to all other navigation apps and vice versa.To fix that, each application now makes a copy of the initial map instead of getting a reference to it.
CLA