Fix switching between non-media and media templates #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds restrictions for templates according to app type Homogenize `trackIcon` and `mainImage` in media and nonMedia models
Jack-Byrne
reviewed
May 17, 2021
app/model/sdl/Abstract/Model.js
Outdated
| } | ||
| case 'NAV_FULLSCREEN_MAP': | ||
| { | ||
| return model.appType.indexOf('NAVIGATION') >= 0; |
There was a problem hiding this comment.
Also check if type is PROJECTION?
There was a problem hiding this comment.
Hmmm, a little surprised there isn't a specific template for that sort of thing, but it does look like PROJECTION should probably be allowed in this case, yeah
Jack-Byrne
approved these changes
May 18, 2021
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #535
This PR is ready for review.
Testing Plan
Manually test switching between templates with various combinations of the
MEDIAandNAVIGATIONapp types. Verify that app info is displayed properly.Summary
Allows media apps to properly use the non-media template. Adds restrictions for
MEDIA,NAV_FULLSCREEN_MAP, andWEB_VIEWtemplates based on app type.Also removes redundant/unused app model fields.
CLA