Fix/hmi doesnt update timeout prompt #606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… timeout reseting
…eout_prompt Fixed issue: HMI does not update the timeout for timeoutPrompt during…
|
Hi @theresalech This is a regression issue (related to OnResetTimeout feature) and PR is ready for Livio team review |
iCollin
requested changes
Sep 14, 2021
| @@ -791,6 +791,8 @@ SDL.SDLController = Em.Object.extend( | |||
| ); | |||
| SDL.SDLModel.data.set('interactionData.vrHelpTitle', null); | |||
| SDL.SDLModel.data.set('interactionData.vrHelp', null); | |||
| clearTimeout(SDL.SDLModel.promptTimeout); | |||
| SDL.SDLModel.set('timeoutPromprtCallback', undefined); | |||
There was a problem hiding this comment.
Suggested change
| SDL.SDLModel.set('timeoutPromprtCallback', undefined); | |
| SDL.SDLModel.set('timeoutPromptCallback', undefined); |
@ValeriiMalkov could you please update the typo in this variable name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #599
This PR is ready] for review.
Testing Plan
Manual testing
Summary
The problem was requesting UI.PI after resetting the timeout. The timeout request did not update the timer.
Added an additional variable to save the timeout for the timeout prompt and the ability to reset it
CLA