Fix/Reset AudioStreamingIndicator to PLAY_PAUSE #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobkeeler
requested changes
May 27, 2021
|
@jacobkeeler Applied suggested change. Also added change to reset audioStreamingIndicator to PLAY_PAUSE when app enters HMI_NONE (as specified in the proposal https://github.com/smartdevicelink/sdl_evolution/blob/master/proposals/0109-set-audio-streaming-indicator.md#hmi--mobile-api) |
jacobkeeler
requested changes
May 28, 2021
jacobkeeler
approved these changes
May 28, 2021
ValeriiMalkov
pushed a commit
to LuxoftSDL/sdl_hmi
that referenced
this pull request
Jul 16, 2021
* Reset audioStreamingIndicator to PLAY_PAUSE if undefined in request * Address review comment * Reset audiostreamingIndicator to PLAY_PAUSE on HMI_NONE * Remove unused RPC case UI.SetAudioStreamingIndicator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements/Fixes #517
This PR is ready for review.
Testing Plan
Run reproduction steps using Test Suite/RPC Builder app
CLA