Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix VR pop-up overlaps the pop-up for timeout resetting during VR.PerfromInteraction #623

Conversation

ValeriiMalkov
Copy link
Contributor

Implements/Fixes #622

This PR is ready for review.

Testing Plan

Manual testing

Summary

ResetTimeoutPopUp moved right

CLA

ValeriiMalkov and others added 2 commits September 23, 2021 11:35
…_popup_during_PI_request

Fixed issue: VR pop-up during VR.PerfromInteraction overlaps the pop-up for timeout resetting
@ValeriiMalkov
Copy link
Contributor Author

Hi @theresalech ! This is a regression issue and ready for livio team review!

@iCollin
Copy link
Collaborator

iCollin commented Sep 23, 2021

@ValeriiMalkov Just FYI we would NOT consider this a regression issue in the context of the 8.0 release. When we say regression issue during release testing, it means that the feature has worked in master before. The reset timeout pop up has never existed in master, therefore an issue with it is not a regression. This issue would be classified as an issue with an 8.0 feature (which is also priority to fix before the release). Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants