Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/Add request type param to pack and unpack requests #293

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Fix/Add request type param to pack and unpack requests #293

merged 1 commit into from
Mar 30, 2020

Conversation

ShobhitAd
Copy link
Contributor

@ShobhitAd ShobhitAd commented Mar 30, 2020 •
edited
Loading

Adds additional params to be sent in the pack/unpack requests to the policy manager script so it can decide how to handle files for different system request types.

This PR is ready for review.

Summary

  1. Add requestType and requestSubType params to pack/unpack requests
  2. Remove duplicate function which was added in 114f854#diff-9c6a0264ae6fa261cae182013bb9ddf0R311

CLA

@ShobhitAd ShobhitAd merged commit 74d2492 into develop Mar 30, 2020
@ShobhitAd ShobhitAd deleted the fix/external_policy_manager_non_proprietary_request branch March 30, 2020 18:56
@AKalinich-Luxoft AKalinich-Luxoft mentioned this pull request Apr 14, 2020
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jack-Byrne Jack-Byrne Jack-Byrne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShobhitAd @Jack-Byrne