Fix SubscribeVehicleData/UnsubscribeVehicleData response #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem that HMI keeps subscription status of applications on SubscribeVehicleData/UnsubscribeVehicleData requests is comming. However this is an SDL responsibility to manage with subscriptions. In this commit was updated HMI logic to provide only list of available vehicle data and just check requested data using it. All logic related to subscriptions were removed.
Jack-Byrne
pushed a commit
that referenced
this pull request
Jan 23, 2018
…t_values Fix current HD channel values dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem that HMI keeps subscription status of applications on
SubscribeVehicleData/UnsubscribeVehicleDatarequests is comming. However this is an SDL responsibilityto manage with subscriptions.
In this commit was updated HMI logic to provide only list of available vehicle data and just check requested data using it. All logic related to subscriptions were removed.
NOTE
This is a PR #33 which just resent to another branch