Fix success response code on jpeg images #372
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Create checkImagesInRequest function that simplifies validation of images. 2. Fix image validation for ScrollableMessage + PerformInteraction RPC
1 task
|
@theresalech please notice that this PR is ready for Livio Team Code Review. |
jacobkeeler
requested changes
Nov 5, 2020
| @@ -274,6 +274,17 @@ SDL.AlertPopUp = Em.ContainerView.create( | |||
| // popUp | |||
| this.set('priority', priority); | |||
| clearTimeout(this.timer); | |||
|
|
|||
| var callback = function(failed) { | |||
| self.reason = 'WARNINGS'; | |||
There was a problem hiding this comment.
Suggested change
| self.reason = 'WARNINGS'; | |
| self.reason = failed ? 'WARNINGS' : 'SUCCESS'; |
| if(request.params.vrHelp) { | ||
| for(var i = 0; i < request.params.vrHelp.length; i++) { | ||
| if(request.params.vrHelp[i].image) { | ||
| imageList.push(request.params.vrHelp[i].image.value); |
There was a problem hiding this comment.
Should there be an isPng check for the images in this function?
|
@YarikMamykin also fix merge conflicts |
iCollin
reviewed
Nov 6, 2020
Comment on lines
+435
to
+437
| const img_extension = '.png'; | ||
| var search_offset = imagePath.lastIndexOf('.'); | ||
| return imagePath.includes(img_extension, search_offset); |
There was a problem hiding this comment.
Suggested change
| const img_extension = '.png'; | |
| var search_offset = imagePath.lastIndexOf('.'); | |
| return imagePath.includes(img_extension, search_offset); | |
| return imagePath.endsWith('.png'); |
|
@iCollin @jacobkeeler because of a lot of conflicts and some architectural changes introduced in release 7.0 it makes sense to completely change this fix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements/Fixes
#319
#321
#329
This PR is ready for review.
WARNING! This PR should be merged only after #344
Changes in this PR are based on changes from PR 344
Testing Plan
Manual testing
Summary
Enhanced image validation function and added check for template non-png images.
CLA