Release 5.4.0 #461
Merged
Release 5.4.0 #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* External OnSystemRequest retry fxes * Address comment fixes
Window capabilities structure has been updated to reflect all the latest changes in app template switching.
Now it will be calculated according to registered app HMI type. Also were removed keyword WEB_ENGINE as there is no such template name.
…_in_nav_view Fix/326 no display mode change in nav view
In case when commands organized in a tree hierarchy there might be a case when applicaiton deletes command with childs. In that case SDL removes parent command first and then all its childs starting from the bottom one. In case when SDL tries to remove the last child, HMI responds with INVALID_ID because it can't find that node by menu_id as its parent was deleted first. To fix that issue, logic of commands removal was updated so now HMI responds with SUCCESS if commandsList contain the array by menuID. It makes more sense because parent node could be deleted first.
* vr USER_EXIT command type changed to application so it appears in all views * use exit action for application vr command exit
…s_list Fix app permissions view when groups are removed
There was noticed that in several cases promise statement continues to execute even after resolve()/reject() was called in early if statement. This is because JS has the concept "run to completion". Unless an error is thrown, a function is executed until a return statement or its end is reached. To fix that, return statements have been placed for cases where resolve/reject is called early. This prevents functions to execute unnecessary code. Since the return value of the callback is ignored, we can save a line by returning the reject/resolve statement.
…s provided (#344) * Fix PerformInteraction + ScrollableMessage response * Fix Show + SetGlobalProperties response * Fix UpdateTurnList + ShowConstantTBT + SendLocation response * Fix AlertManeuverPopUp response * Fix AddCommand + AddSubMenu response * fixup! Fix AddCommand + AddSubMenu response * fixup! Fix AddCommand + AddSubMenu response Co-authored-by: YarikMamykin <ymamykin@gmail.com> Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com>
#368) * Fix softButton is not displayed properly in day/night/highlighted mode * updated fix softButton is not displayed properly in day/night/highlighted mode * fixup! updated fix softButton is not displayed properly in day/night/highlighted mode Co-authored-by: yurii <ypostolov> Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com>
* Replace multiple getters with a signgle variable * Fix TypeError while iterating veHelp Was added one more check to verify if vrHelp item contains image object or not as it might be not mandatory according to HMI_API. * fixup! Fix TypeError while iterating veHelp * fixup! Fix TypeError while iterating veHelp
* Fix sending errorneous response with params According to SDL specification there is no custom API params expected in "data" section of erorneous response by desgin. By that reason SDL just cuts off all such params and ignores their values. In particular case, SDL ignores `tryAgainTime` of SubtleAlert errorneous response and does not forward it to mobile. To avoid such issues, errorneous responses with custom params from API should be sent in the `result` section of response. Corresponding function has been updated to cover this test case. For case of errorneous response without custom params, errorneous message can be sent as usual. * send warnings with info in error format * move result adjustment to after error check * remove info from success schema, apply to all interfaces * fixup! remove info from success schema, apply to all interfaces fix whitespace in ttsrpc.js * apply for any success code, add TODO note * remove result code check from sendError on each interface * Update ffw/NavigationRPC.js Co-authored-by: JackLivio <jack@livio.io> * apply params changes to each interface * fix spelling and whitespace Co-authored-by: Andrii Kalinich <AKalinich@luxoft.com> Co-authored-by: JackLivio <jack@livio.io>
…d_SubtleAlert_related_text_fields Added SubtleAlert RPC missing text fields in UI.GetCapabilities response
Fix vehicle data issues found during testing
…ource_processing Process remaining show message params in case of UNSUPPORTED_RESOURCE
…on messages (#437) Co-authored-by: yurii <ypostolov>
HMI internal commands should be added by default for each application and should not depend on HMI settings. Added check to make an exception for such commands.
* Fix AlertManeuver buttons behavior Do not display system defined close button when soft buttons are shown. To keep context for AlertManeuver, HMI should reset timeout using TTS interface as SDL does not listen to UI part. * Add default action to close button Also action was replaced with actionUp to avoid unnecessary buttonUp events capturing by controls on the bottom view.
* Fix response params forwarding There was noticed a regression that HMI does not forward params in case of error. This is because of complicated and wrong logic of calculation of some corner cases. To avoid that, condition was reformatted as a more readable separate function. * Apply fix for the rest of interfaces
HMI should not sent empty permission consents to SDL as this is invalid notification according to API. Also, was fixed appID parameter for a selected application.
* Add template images support for POI list There was missing button template type for a left text overlay. Also, template style was not applied when list items were constructed initially * Added image mode support for missing elements
The was noticed a wrong image validation logic in mentioned rpcs. In all cases HMI responds twice - first time with regular result code and the second time with the result of images validation. To fix that, image validation has been placed into the proper place in the code and appropriate breaks were added. Also, was added timer stop for AlertManeuver popup.
Jack-Byrne
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed Features
[SDL 0252] Aligning HMI and MOBILE API for pcmStreamCapabilities
[SDL 0253] New vehicle data StabilityControlsStatus
[SDL 0266] New vehicle data GearStatus
[SDL 0148] Template Improvements: Additional SubMenus
[SDL 0152] Driver Distraction Improvements: Command List Limitations
[SDL 0261] New vehicle data WindowStatus
[SDL 0257] New vehicle data HandsOffSteering
[SDL 0202] Supported Character Sets
[SDL 0242] Subtle Alert Style
[SDL 0268] Main Menu Updating and Pagination
[SDL 0273] WebEngine Projection mode
[SDL 0190] Handle response from HMI during resumption data
SDL 0188 - Interior Vehicle Data Resumption
[SDL 0256] Refactor Fuel Information Related Vehicle Data
[SDL 0249] Persisting HMI Capabilities specific to headunit
Completed Bug Fixes/Enhancements
Unsupported externalTemperature value
HMI provides all CLIMATE data in case climateEnable=false
Image is displayed right on the text on POI items
HMI sends BasicCommunication.onReady notification two times
HMI sends redundant "steeringWheelLocation" parameter in UI.GetCapabilities response
HMI shows SEAT paramers only for one moduleId
HMI sends OnInteriorVehicleData notification with incorrect type of frequencyInteger on press XM radio preset button on HMI
Uncaught TypeError: Cannot read property 'get' of null on FFW.UI.OnSystemContext
HMI does not perform predefined actions by clicking the custom softButtons on AlertManeuver pop-up
TypeError after clicking play, next/previous track button on audio_source tabs
HMI should use PLAY_PAUSE button name instead of OK
AlertManeuver pop-up displays the softButtons from previous requests
Error in the HMI console in case on HMI select Day/Night/Highlighted mode
WARNINGS resultCode instead of UNSUPPORTED_RESOURCE to PerformInteraction with ChoiceSet added with STATIC image type
HMI is unable to send OnExitApplication with ApplicationExitReason : CLOSE_CLOUD_CONNECTION
HMI does not send SetAppProperties request on press Set button on HMI
HMI renews Channel Set for current shown id only after switching screen to another item
POI list is updated only after removing some existed element
Fix menu ordering based on position param
HMI responds with WARNINGS resultCode instead of UNSUPPORTED_RESOURCE to Show request with STATIC image type
Add support for custom menu icon and title
HMI sends displayMode=AUTO in OnInteriotVehicleData notif and SetInteriorVehicleData response
Display mode is not applicable for POI list
HMI sends BC.OnSystemRequest notification without requestType: "PROPRIETARY"
Error response on DeleteSubMenu request for nested submenu in case of delete the top level submenu
HMI does not remove the group entries in app permissions list
HMI does not send resultCode: "WARNINGS" + "message: Requested image(s) not found" from HMI in case Image is invalid
HMI responds with WARNINGS code in case core requests AddCommand with image
Error in SDL_HMI when clicking the 'X' to exit Keyboard
Web app with HMI type WEB_VIEW is not registered and activated
AlertManeuver: SoftButton with an icon is not displayed in day/night/Highlighted mode
send warnings with info in error format
TypeError by file deleting