Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kill running webengine app when it is uninstalled #487

Merged
merged 2 commits into from
Mar 3, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions app/controller/InfoController.js
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,16 @@ SDL.InfoController = Em.Object.create(
onAppPropertiesNotification: function(new_properties) {
let updated_properties = this.updateAppProperties(new_properties);

if (!new_properties.enabled
&& new_properties.policyAppID in SDL.SDLModel.webApplicationFramesMap) {
let frame = SDL.SDLModel.webApplicationFramesMap[new_properties.policyAppID];
const web_engine_view = document.getElementById("webEngineView");
if (web_engine_view) {
web_engine_view.removeChild(frame);
}
delete SDL.SDLModel.webApplicationFramesMap[new_properties.policyAppID];
}

var current_policy_app_id = SDL.WebAppSettingsView.editorAppSettings.policyAppID;
if (current_policy_app_id != updated_properties.policyAppID) {
// Don't refresh displayed properties for a different app
Expand Down