Fix/fix hmi sends deprecated OnFindApplications notification #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ypostolov We will review, thank you. For future Pr's please include more testing details other than "manual test plan". |
|
@Ypostolov Missed a reference to find new apps in eng.js
|
@JackLivio |
Jack-Byrne
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements/Fixes [#509 ]
This PR is ready for review.
Testing Plan
Covered by manual test plan
Summary
Was fixed sending deprecated notification OnFindApplications to SDL. Also was removed button "Find New Apps" as it also sent deprecated notification OnFindApplications.
CLA