Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

don't send activate app with null app id #532

Merged
merged 5 commits into from
Mar 23, 2021
Merged

don't send activate app with null app id #532

merged 5 commits into from
Mar 23, 2021

Conversation

iCollin
Copy link
Collaborator

@iCollin iCollin commented Mar 22, 2021

Implements/Fixes #531

This PR is ready for review.

Summary

don't send Activate App with a null appId

CLA

jacobkeeler
jacobkeeler requested changes Mar 23, 2021
View reviewed changes
Copy link
Contributor

@jacobkeeler jacobkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the console error that was occurring, but the media screen still doesn't open when selected.

@iCollin iCollin changed the base branch from develop to release/5.5.0 March 23, 2021 17:16
@iCollin iCollin merged commit cc7c590 into release/5.5.0 Mar 23, 2021
@iCollin iCollin deleted the fix/activate_null_app branch March 23, 2021 18:03
@iCollin iCollin mentioned this pull request Mar 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jacobkeeler jacobkeeler jacobkeeler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iCollin @jacobkeeler