Fix/on keyboard input behavior #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobkeeler
requested changes
Mar 24, 2021
There was a problem hiding this comment.
It was intended behavior for the the user preference to be reset whenever the keyboard was closed, see #484. This behavior came from the proposal as defined here:
"USER_CHOICE_INPUT_KEY_MASK" - HMI should mask entered characters, however, HMI should allow Users to change this and see input characters. HMI would provide a key to unmask characters.
This is also how the Generic HMI implementation behaves as well. This PR currently breaks that behavior
jacobkeeler
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements/Fixes #529 & #528
This PR is Ready for review.
Testing Plan
As described by reproduction steps included in linked issues.
Summary
CLA