Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SDL 0192 Button Subscription response from HMI #580

Merged
merged 18 commits into from
Aug 12, 2021
Merged

SDL 0192 Button Subscription response from HMI #580

Show file tree
Hide file tree
Changes from 14 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
5dc3727
SDL-0192 Removed OnButtonSubscription notification from HMI
ValeriiMalkov Jul 5, 2021
a04fbe8
SDL-0192 Extended settings controller for apps to customize Subscribe…
ValeriiMalkov Jul 6, 2021
677e97a
SDL-0192 Created separate file for button capabilites
ValeriiMalkov Jul 6, 2021
4dcdb83
SDL-0192 Updated RPC Helper
ValeriiMalkov Jul 6, 2021
ad678bd
SDL-0192 Added SubscribeButton/UnsubscribeButton RPC's processing
ValeriiMalkov Jul 6, 2021
52fe15f
Fix naming and formatting
Jul 28, 2021
dbae671
Merge pull request #105 from LuxoftSDL/review/SDL-0192-Button-Subscri…
Jul 28, 2021
03362ea
SDL-0192 Replaced throw -> return in RPCHelper.js
ValeriiMalkov Aug 5, 2021
20e8abe
SDL-0192 Replace REJECTED res code with SUCCESS if button not subscribed
ValeriiMalkov Aug 5, 2021
c99faa2
SDL-0192 Removed tracking of which button is subscribed
ValeriiMalkov Aug 5, 2021
7174dcb
SDL-0192 SDL.ButtonCapability used in display_capabilities
ValeriiMalkov Aug 5, 2021
f62e0a4
SDL--0192 Changed logic inside SubscribeButton method
ValeriiMalkov Aug 6, 2021
54b806b
SDL-0192 Renamed method navButtonSubscriptionToggle -> setNavButtonSu…
ValeriiMalkov Aug 6, 2021
e19da15
SDL-0192 Fixed typo
ValeriiMalkov Aug 6, 2021
7dc86b8
SDL-0192 Minor fix
ValeriiMalkov Aug 9, 2021
5563ddf
SDL-0192 Answer for review
ValeriiMalkov Aug 9, 2021
20657c6
SDL-0192 Fix button subscription
ValeriiMalkov Aug 10, 2021
bc91ea3
SDL-0192 Answer for review comment
ValeriiMalkov Aug 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/controller/SettingsController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,8 @@ SDL.SettingsController = Em.Object.create(
SDL.States.goToStates('settings.' + event.goToState);
if('rpccontrol.rpcconfig' === event.goToState){
SDL.RPCControlConfigView.set('appNameLabel.content',event.appName);
SDL.RPCControlConfigView.SubscribeButton.initSubscribeButtonView();
SDL.RPCControlConfigView.UnsubscribeButton.initUnsubscribeButtonView();
FFW.RPCHelper.updateRpc(event.appID);
}
},
Expand Down
Loading