Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Add Missing WEB_VIEW display capabilities #688

Merged
merged 4 commits into from
Jul 29, 2022

Conversation

ShobhitAd
Copy link
Contributor

@ShobhitAd ShobhitAd commented Jul 20, 2022

Fixes #686

This PR is ready for review.

Testing Plan

  1. Start policy server
  2. Add the following entry in sdl_preloaded_pt.json
            "45b2c12c-a289-4c08-b4e4-bee768bf0cf9": {
                "AppHMIType": [ "WEB_VIEW" ],
                "keep_context": false,
                "steal_focus": false,
                "priority": "NONE",
                "default_hmi": "NONE",
                "groups": ["Base-4", "WidgetSupport"],
                "hybrid_app_preference": "CLOUD",
                "enabled": false,
                "transport_type ": "WS"
            },
  1. Change the appStoreUrl in Flags.js to http://localhost:3000/api/v1/applications/store
  2. Start core and HMI
  3. In the HMI, enable the "Hello Webengine3" app in the app store and activate the app
  4. In the WEB_VIEW change the display layout to NON-MEDIA
  5. Click on Options -> Return to WEB_VIEW

CLA

capabilities/display_capabilities.js Show resolved Hide resolved
capabilities/display_capabilities.js Show resolved Hide resolved
capabilities/display_capabilities.js Outdated Show resolved Hide resolved
@jacobkeeler
Copy link
Contributor

Approving, though I will note two unrelated issues I found during testing

  1. It seems ONSCREEN_PRESETS is missing from the template list of several of the templates.
  2. Using the flow you gave in the PR description, I get an error. If you try to switch to NON-MEDIA from WEB_VIEW and back, it seems several things go wrong with the HMI state at the moment.

@ShobhitAd ShobhitAd merged commit 4c96499 into develop Jul 29, 2022
@ShobhitAd ShobhitAd deleted the fix/missing_web_view_display_capabilities branch July 29, 2022 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants