Skip to content

Feature/service status update to hmi #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Aug 29, 2019
Merged

Feature/service status update to hmi #154

merged 20 commits into from
Aug 29, 2019

Conversation

@mked-luxoft
Copy link
Contributor

@mked-luxoft mked-luxoft commented May 22, 2019

Provides the information for #2791

Proposal
This PR is ready for review.

Summary

Create OnServiceUpdate folder; update config json with OnServiceUpdate

CLA

@mked-luxoft mked-luxoft changed the base branch from master to develop May 22, 2019 17:46
@mked-luxoft mked-luxoft mentioned this pull request May 22, 2019
Merged
1 task
@sdl-robot
Copy link

sdl-robot commented May 22, 2019

Preview this pull request at https://smartdevicelink.com/en/docs/pull_request/ea499f498c2e76ae5de64755616971360774efb5/overview/

@SNiukalov SNiukalov force-pushed the feature/service_status_update_to_hmi branch from ea499f4 to a102b79 Compare May 30, 2019 10:47
@sdl-robot
Copy link

sdl-robot commented May 30, 2019

Preview this pull request at https://smartdevicelink.com/en/docs/pull_request/a102b797a70a6b48db98d9655fef8026a2b7ec0e/overview/

@sdl-robot
Copy link

sdl-robot commented Jun 12, 2019

Preview this pull request at https://smartdevicelink.com/en/docs/pull_request/5596b2b7ff83237610e3f7b747fb059c07dff6e6/overview/

@sdl-robot
Copy link

sdl-robot commented Jun 12, 2019

Preview this pull request at https://smartdevicelink.com/en/docs/pull_request/afafb5b96ecc5fc1b095d91f02f0a48a824bb6f2/overview/

@mked-luxoft
Copy link
Contributor Author

mked-luxoft commented Jun 14, 2019

@yang1070 This PR was updated to comply with proposal updates. Please review.

@mked-luxoft mked-luxoft requested a review from yang1070 June 14, 2019 13:57
@mked-luxoft mked-luxoft force-pushed the feature/service_status_update_to_hmi branch from afafb5b to 9d731b3 Compare June 14, 2019 14:06
@sdl-robot
Copy link

sdl-robot commented Jun 14, 2019

Preview this pull request at https://smartdevicelink.com/en/docs/pull_request/9d731b36a7882187f7c7a587a15fe7fcdd667b23/overview/

KhrystynaDubovyk and others added 13 commits June 14, 2019 17:20
@KhrystynaDubovyk @mked-luxoft
Create OnServiceUpdate folder; update config json with OnServiceUpdate
5515d99
@KhrystynaDubovyk @mked-luxoft
Add ServiceType, ServiceEvent, ServiceUpdateReason enums
73a151e
@KhrystynaDubovyk @mked-luxoft
fixing links, minor text formatting
37db219
@KhrystynaDubovyk @mked-luxoft
fix ServiceUpdateReason table syntax
624285a
@KhrystynaDubovyk @mked-luxoft
add assets folder
1ab2703
@KhrystynaDubovyk @mked-luxoft
replacing the note
bc7b1b9
@KhrystynaDubovyk @mked-luxoft
Update diagram
b497b75
@KhrystynaDubovyk @mked-luxoft
remove 'appropriate' to avoid ambiguity
364eb9f
@KhrystynaDubovyk @mked-luxoft
Update index.md
2c3dd65
@KhrystynaDubovyk @mked-luxoft
rename enum ServiceUpdateReason into ServiceStatusUpdateReason
446ed52 
develop already has `ServiceUpdateReason` brought with AppServices  https://github.com/smartdevicelink/sdl_core/blob/develop/src/components/interfaces/HMI_API.xml#L3742
@KhrystynaDubovyk @mked-luxoft
update ServiceUpdateReason into ServiceStatusUpdateReason
f9b36c5
@KhrystynaDubovyk @mked-luxoft
add PROTECTION_ENFORCED, PROTECTION_DISABLED to ServiceStatusUpda…
638abaf 
…teReason
@KhrystynaDubovyk @mked-luxoft
added the source file for the included diagram
628084d
@mked-luxoft mked-luxoft force-pushed the feature/service_status_update_to_hmi branch from 9d731b3 to 628084d Compare June 14, 2019 14:21
@sdl-robot
Copy link

sdl-robot commented Jun 14, 2019

Preview this pull request at https://smartdevicelink.com/en/docs/pull_request/628084d6ec305d6bab228f4bfa988f1aca1d358d/overview/

yang1070
yang1070 approved these changes Jun 14, 2019
View reviewed changes
Copy link

@yang1070 yang1070 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ford has reviewed and approved this change

@AStasiuk
Copy link

AStasiuk commented Aug 20, 2019

@theresalech, this PR is already reviewed and approved by Ford (by @yang1070 ) and ready for Livio review.

jacobkeeler
jacobkeeler requested changes Aug 21, 2019
View reviewed changes
mked-luxoft and others added 3 commits August 21, 2019 18:47
@mked-luxoft @jacobkeeler
Update docs/BasicCommunication/OnServiceUpdate/index.md
6f1e112 
Co-Authored-By: Jacob Keeler <jacob.keeler@livioradio.com>
@mked-luxoft @jacobkeeler
Update docs/Common/Enums/index.md
fc7128f 
Co-Authored-By: Jacob Keeler <jacob.keeler@livioradio.com>
@mked-luxoft @jacobkeeler
Update docs/Common/Enums/index.md
b50bdf8 
Co-Authored-By: Jacob Keeler <jacob.keeler@livioradio.com>
@sdl-robot
Copy link

sdl-robot commented Aug 21, 2019

Preview this pull request for HMI Documentation:

https://staging.smartdevicelink.com/en/guides/pull_request/hmi/fc7128f6dbbaff7b81011e498434935d0f0b9848/overview/

1 similar comment
@sdl-robot
Copy link

sdl-robot commented Aug 21, 2019

Preview this pull request for HMI Documentation:

https://staging.smartdevicelink.com/en/guides/pull_request/hmi/fc7128f6dbbaff7b81011e498434935d0f0b9848/overview/

@sdl-robot
Copy link

sdl-robot commented Aug 21, 2019

Preview this pull request for HMI Documentation:

https://staging.smartdevicelink.com/en/guides/pull_request/hmi/6f1e1127bb8e906e7e972c4c149c4b04cc2a8f23/overview/

1 similar comment
@sdl-robot
Copy link

sdl-robot commented Aug 21, 2019

Preview this pull request for HMI Documentation:

https://staging.smartdevicelink.com/en/guides/pull_request/hmi/6f1e1127bb8e906e7e972c4c149c4b04cc2a8f23/overview/

@sdl-robot
Copy link

sdl-robot commented Aug 21, 2019

Preview this pull request for HMI Documentation:

https://smartdevicelink.com/en/guides/pull_request/hmi/6f1e1127bb8e906e7e972c4c149c4b04cc2a8f23/overview/

@sdl-robot
Copy link

sdl-robot commented Aug 21, 2019

Preview this pull request for HMI Documentation:

https://staging.smartdevicelink.com/en/guides/pull_request/hmi/b50bdf8bde514f26cc68c2998309f5f07f2d20da/overview/

@sdl-robot
Copy link

sdl-robot commented Aug 21, 2019

Preview this pull request for HMI Documentation:

https://smartdevicelink.com/en/guides/pull_request/hmi/b50bdf8bde514f26cc68c2998309f5f07f2d20da/overview/

2 similar comments
@sdl-robot
Copy link

sdl-robot commented Aug 21, 2019

Preview this pull request for HMI Documentation:

https://smartdevicelink.com/en/guides/pull_request/hmi/b50bdf8bde514f26cc68c2998309f5f07f2d20da/overview/

@sdl-robot
Copy link

sdl-robot commented Aug 21, 2019

Preview this pull request for HMI Documentation:

https://smartdevicelink.com/en/guides/pull_request/hmi/b50bdf8bde514f26cc68c2998309f5f07f2d20da/overview/

jacobkeeler
jacobkeeler reviewed Aug 21, 2019
View reviewed changes
Copy link
Contributor

@jacobkeeler jacobkeeler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: you can batch suggestions together so that fewer commits are created when making changes

KhrystynaDubovyk and others added 2 commits August 22, 2019 12:08
@KhrystynaDubovyk @jacobkeeler
Apply suggestions from code review
8aac9f3 
Co-Authored-By: Jacob Keeler <jacob.keeler@livioradio.com>
@KhrystynaDubovyk @jacobkeeler
Update docs/BasicCommunication/OnServiceUpdate/index.md
765418c 
Co-Authored-By: Jacob Keeler <jacob.keeler@livioradio.com>
@sdl-robot
Copy link

sdl-robot commented Aug 22, 2019

Preview this pull request for HMI Documentation:

https://staging.smartdevicelink.com/en/guides/pull_request/hmi/8aac9f3907a17aea03a91aff1cb0c99543be3b30/overview/

@sdl-robot
Copy link

sdl-robot commented Aug 22, 2019

Preview this pull request for HMI Documentation:

https://smartdevicelink.com/en/guides/pull_request/hmi/8aac9f3907a17aea03a91aff1cb0c99543be3b30/overview/

@sdl-robot
Copy link

sdl-robot commented Aug 22, 2019

Preview this pull request for HMI Documentation:

https://smartdevicelink.com/en/guides/pull_request/hmi/765418cd4e740aa058db1f4b146bb9e0fe5ae7c0/overview/

@sdl-robot
Copy link

sdl-robot commented Aug 22, 2019

Preview this pull request for HMI Documentation:

https://staging.smartdevicelink.com/en/guides/pull_request/hmi/765418cd4e740aa058db1f4b146bb9e0fe5ae7c0/overview/

jacobkeeler
jacobkeeler requested changes Aug 26, 2019
View reviewed changes
@KhrystynaDubovyk @jacobkeeler
Update docs/BasicCommunication/OnServiceUpdate/index.md
9eb2e45 
Co-Authored-By: Jacob Keeler <jacob.keeler@livioradio.com>
@sdl-robot
Copy link

sdl-robot commented Aug 27, 2019

Preview this pull request for HMI Documentation:

https://staging.smartdevicelink.com/en/guides/pull_request/hmi/9eb2e45b717afae0ac4a2cc6dbca2b120f41ac7f/overview/

@sdl-robot
Copy link

sdl-robot commented Aug 27, 2019

Preview this pull request for HMI Documentation:

https://smartdevicelink.com/en/guides/pull_request/hmi/9eb2e45b717afae0ac4a2cc6dbca2b120f41ac7f/overview/

@sdl-robot
Copy link

sdl-robot commented Aug 27, 2019

Preview this pull request for HMI Documentation:

https://staging.smartdevicelink.com/en/guides/pull_request/hmi/00f4bd096912fb623d112d43182ef64b671bea5e/overview/

@sdl-robot
Copy link

sdl-robot commented Aug 27, 2019

Preview this pull request for HMI Documentation:

https://smartdevicelink.com/en/guides/pull_request/hmi/00f4bd096912fb623d112d43182ef64b671bea5e/overview/

@jacobkeeler jacobkeeler merged commit c2b3c3f into develop Aug 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacobkeeler jacobkeeler jacobkeeler approved these changes

@Jack-Byrne Jack-Byrne Awaiting requested review from Jack-Byrne

+2 more reviewers

@KhrystynaDubovyk KhrystynaDubovyk KhrystynaDubovyk left review comments

@yang1070 yang1070 yang1070 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mked-luxoft @sdl-robot @AStasiuk @jacobkeeler @yang1070 @KhrystynaDubovyk