Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/read generic network signal data clarification #170

Conversation

KhrystynaDubovyk
Copy link
Contributor

@KhrystynaDubovyk KhrystynaDubovyk commented Aug 2, 2019

Provides the information for [SDL 0173] - Read Generic Network Signal Data Clarification

This PR is ready for review.

Summary

upd Enums index - VehicleDataType -> add VEHICLEDATA_OEM_CUSTOM_DATA
upd SubscribeVehicleData index
upd UnsubscribeVehicleData index

CLA

@sdl-robot
Copy link

Preview this pull request for HMI Documentation:

https://staging.smartdevicelink.com/en/guides/pull_request/hmi/9346fd95b9df9957fe9a30f6b111b48807439857/overview/

Warning - GetURLS in navigation config is not found in navigation paths

@sdl-robot
Copy link

Preview this pull request for HMI Documentation:

https://smartdevicelink.com/en/guides/pull_request/hmi/9346fd95b9df9957fe9a30f6b111b48807439857/overview/

Warning - GetURLS in navigation config is not found in navigation paths

@KhrystynaDubovyk KhrystynaDubovyk force-pushed the feature/read_generic_networc_signal_data_clarification branch from 9346fd9 to f05f031 Compare August 2, 2019 12:51
@sdl-robot
Copy link

Preview this pull request for HMI Documentation:

https://staging.smartdevicelink.com/en/guides/pull_request/hmi/f05f031c2a1301b94ed33bba2de511a75fb2f011/overview/

Warning - GetURLS in navigation config is not found in navigation paths

@sdl-robot
Copy link

Preview this pull request for HMI Documentation:

https://smartdevicelink.com/en/guides/pull_request/hmi/f05f031c2a1301b94ed33bba2de511a75fb2f011/overview/

Warning - GetURLS in navigation config is not found in navigation paths

@KhrystynaDubovyk KhrystynaDubovyk changed the title Feature/read generic networc signal data clarification Feature/read generic network signal data clarification Aug 2, 2019
@atiwari9
Copy link

atiwari9 commented Aug 2, 2019

Approved

@LuxoftAKutsan
Copy link
Contributor

Merge to feature branch after accepting smartdevicelink/sdl_evolution#806

@LuxoftAKutsan LuxoftAKutsan merged commit 33d89b2 into feature/read_generic_network_signal_data Aug 23, 2019
@LuxoftAKutsan LuxoftAKutsan deleted the feature/read_generic_networc_signal_data_clarification branch August 23, 2019 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants