Fixed issue with incorrectly parsing SDLRPCResponses.

smartdevicelink · Jan 20, 2017 · 36dc4c2 · 36dc4c2
1 parent b7b20f4
commit 36dc4c2
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 6 deletions.
diff --git a/SmartDeviceLink/SDLRPCResponse.m b/SmartDeviceLink/SDLRPCResponse.m
@@ -45,27 +45,27 @@ - (void)setCorrelationID:(NSNumber<SDLInt> *)corrID {
 }
 
 - (void)setSuccess:(NSNumber<SDLBool> *)success {
-    [store sdl_setObject:success forName:SDLNameSuccess];
+    [parameters sdl_setObject:success forName:SDLNameSuccess];
 }
 
 - (NSNumber<SDLBool> *)success {
-    return [store sdl_objectForName:SDLNameSuccess];
+    return [parameters sdl_objectForName:SDLNameSuccess];
 }
 
 - (void)setResultCode:(SDLResult)resultCode {
-    [store sdl_setObject:resultCode forName:SDLNameResultCode];
+    [parameters sdl_setObject:resultCode forName:SDLNameResultCode];
 }
 
 - (SDLResult)resultCode {
-    return [store sdl_objectForName:SDLNameResultCode];
+    return [parameters sdl_objectForName:SDLNameResultCode];
 }
 
 - (void)setInfo:(nullable NSString *)info {
-    [store sdl_setObject:info forName:SDLNameInfo];
+    [parameters sdl_setObject:info forName:SDLNameInfo];
 }
 
 - (nullable NSString *)info {
-    return [store sdl_objectForName:SDLNameInfo];
+    return [parameters sdl_objectForName:SDLNameInfo];
 }
 
 @end

diff --git a/SmartDeviceLinkTests/RPCSpecs/SuperclassSpecs/SDLRPCResponseSpec.m b/SmartDeviceLinkTests/RPCSpecs/SuperclassSpecs/SDLRPCResponseSpec.m
@@ -8,6 +8,7 @@
 #import <Quick/Quick.h>
 #import <Nimble/Nimble.h>
 
+#import "SDLNames.h"
 #import "SDLResult.h"
 #import "SDLRPCResponse.h"
 
@@ -28,6 +29,24 @@
         expect(response.resultCode).to(equal(SDLResultIgnored));
         expect(response.info).to(equal(@"It has been done"));
     });
+
+    it(@"Should get correctly when initialized", ^ {
+        NSMutableDictionary* dict = [@{SDLNameResponse:
+                                           @{SDLNameParameters:
+                                                 @{SDLNameSuccess:@YES,
+                                                   SDLNameResultCode:SDLNameSuccess,
+                                                   SDLNameInfo:@"Test Info"},
+                                             SDLNameCorrelationId:@1004,
+                                             SDLNameOperationName:SDLNameResponse}} mutableCopy];
+        SDLRPCResponse* testResponse = [[SDLRPCResponse alloc] initWithDictionary:dict];
+
+        expect(testResponse.getFunctionName).to(equal(SDLNameResponse));
+        expect(testResponse.correlationID).to(equal(@1004));
+        expect(testResponse.success).to(equal(@YES));
+        expect(testResponse.resultCode).to(equal(SDLNameSuccess));
+        expect(testResponse.info).to(equal(@"Test Info"));
+
+    });
 });
 
 QuickSpecEnd