Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDL 0282] Screen Manager Alert Manager #1579

Closed
theresalech opened this issue Mar 9, 2020 · 1 comment · Fixed by #1861
Closed

[SDL 0282] Screen Manager Alert Manager #1579

theresalech opened this issue Mar 9, 2020 · 1 comment · Fixed by #1861
Assignees
Labels
manager-screen Relating to the manager layer - screen managers proposal Accepted SDL Evolution Proposal

Comments

@theresalech
Copy link
Contributor

Proposal: Screen Manager Alert Manager

This proposal adds alert management (based on the Alert RPC) to the screen manager API.

Review: smartdevicelink/sdl_evolution#948

Steering Committee Decision:

The Steering Committee voted to accept this proposal with the following revisions:

  • Use a builder pattern as described in this comment.
  • Change SDLAlertAudioData to be a subclass of SDLAudioData.
  • Change the audio data property and initializer to take an array to allow for multiple pieces of audio data.
  • Clarify "if the error value is present, then the alert failed to appear or the user aborted it, if not, then the alert dismissed without error." within the inline documentation for presentAlert.

The proposal .md file was updated to reflect these revisions on 3/9/2020.

@theresalech theresalech added the proposal Accepted SDL Evolution Proposal label Mar 9, 2020
@joeljfischer joeljfischer added the manager-screen Relating to the manager layer - screen managers label Jul 8, 2020
@NicoleYarroch NicoleYarroch self-assigned this Nov 9, 2020
@NicoleYarroch NicoleYarroch linked a pull request Jan 7, 2021 that will close this issue
18 tasks
@jordynmackool
Copy link
Contributor

The proposal markdown file has been updated per the revisions included in the accepted Revise SDL-0282 Screen Manager Alert Manager.

Accepted revisions can be reviewed in the merged PR here: smartdevicelink/sdl_evolution#1111.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
manager-screen Relating to the manager layer - screen managers proposal Accepted SDL Evolution Proposal
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants