-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDL 0282 - Alert Manager #1861
Merged
Merged
SDL 0282 - Alert Manager #1861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
NicoleYarroch
added
manager-screen
Relating to the manager layer - screen managers
proposal
Accepted SDL Evolution Proposal
labels
Nov 25, 2020
Codecov Report
@@ Coverage Diff @@
## develop #1861 +/- ##
===========================================
+ Coverage 85.01% 85.41% +0.40%
===========================================
Files 429 434 +5
Lines 21640 22089 +449
===========================================
+ Hits 18397 18868 +471
+ Misses 3243 3221 -22 |
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io> # Conflicts: # SmartDeviceLink-iOS.xcodeproj/project.pbxproj
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
joeljfischer
suggested changes
Feb 3, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just small comments
Audio data fixes Co-authored-by: Joel Fischer <joeljfischer@gmail.com>
custom error fixes Co-authored-by: Joel Fischer <joeljfischer@gmail.com>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Updated present alert operation Co-authored-by: Joel Fischer <joeljfischer@gmail.com>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
Signed-off-by: NicoleYarroch <nicole@livio.io>
joeljfischer
suggested changes
Feb 4, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more minor point.
Co-authored-by: Joel Fischer <joeljfischer@gmail.com>
joeljfischer
approved these changes
Feb 4, 2021
Signed-off-by: NicoleYarroch <nicole@livio.io> # Conflicts: # SmartDeviceLink-iOS.xcodeproj/project.pbxproj # SmartDeviceLinkTests/RPCSpecs/StructSpecs/SDLWindowCapabilitySpec.m
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
manager-screen
Relating to the manager layer - screen managers
proposal
Accepted SDL Evolution Proposal
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1579
Risk
This PR makes minor API changes.
Testing Plan
Unit Tests
Unit tests were added for the new alert manager classes.
Core Tests
text
,secondaryText
oraudio
set in theSDLAlertView
- a custom error should be returned in the completion handlerSDLAlertView
and connect to a module supporting RPC Spec version less than 5.0 - a custom error should be returned in the completion handlerCore version / branch / commit hash / module tested against: SYNC 3.0 and Manticore (SDL Core v6.1.1)
HMI name / version / branch / commit hash / module tested against: SYNC 3.0 and Manticore (Generic HMI v0.8.1)
Summary
Implements proposal SDL 0282 which adds alert management (based on the Alert RPC) to the screen manager API.
Changelog
Enhancements
Tasks Remaining:
CLA