Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw an exception in the soft button manager if two buttons have the same name #1897

Closed
NicoleYarroch opened this issue Jan 20, 2021 · 0 comments
Assignees
Labels
bug A defect in the library manager-screen Relating to the manager layer - screen managers

Comments

@NicoleYarroch
Copy link
Contributor

Bug Report

Currently in the SDLSoftButtonManager, if two buttons have the same name, an error is logged. We should instead throw an exception since the soft buttons will be removed from the display because the soft button property is set to an empty array.

Reproduction Steps
  1. Create two soft button objects with the same name. Send the soft buttons using the screen manager.
Expected Behavior

An exception should be thrown.

Observed Behavior

An error is logged and the softButtonObjects property is set to an empty array.

OS & Version Information
  • iOS Version: n/a
  • SDL iOS Version: 7.0
  • Testing Against: n/a
@NicoleYarroch NicoleYarroch added the bug A defect in the library label Jan 20, 2021
@joeljfischer joeljfischer added the manager-screen Relating to the manager layer - screen managers label Jan 20, 2021
@FrankElias77 FrankElias77 self-assigned this Jan 25, 2021
@joeljfischer joeljfischer mentioned this issue Mar 15, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library manager-screen Relating to the manager layer - screen managers
Projects
None yet
Development

No branches or pull requests

3 participants