Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code Style should match Objective-C guidelines #2

Closed
joeljfischer opened this issue Oct 24, 2014 · 0 comments
Closed

Code Style should match Objective-C guidelines #2

joeljfischer opened this issue Oct 24, 2014 · 0 comments
Labels
best practice Not a defect but something that should be improved anyway

Comments

@joeljfischer
Copy link
Contributor

Currently most code is styled incorrectly according to Apple's Coding Guidelines for Cocoa.

I also really like the New York Times Objective-C Style Guile with only a few disagreements.
@joeljfischer joeljfischer added enhancement documentation Relating to inline documentation best practice Not a defect but something that should be improved anyway and removed enhancement documentation Relating to inline documentation labels Oct 24, 2014
mrapitis pushed a commit to mrapitis/sdl_ios that referenced this issue Sep 21, 2017
@piyushkhosla
Merge pull request smartdevicelink#2 from mrapitis/feature/rc_rpcs
6d95f76 
changes for review comments, merged in base branch of release/5.0.0
davidswi pushed a commit to davidswi/sdl_ios that referenced this issue Nov 15, 2017
@madhuy
Merge pull request smartdevicelink#2 in UIES/sdl_ios from bugfix/sess…
d49c397 
…ion_cleanup to xevo_master

* commit '4bb77c50850ac0bceabab3c09a360ed6efa2a400':
  Per revieew feedback reinstate data session = nil and add control session = nil.
  Per review feedback remove clearHandlers and else block in disconnect.
  Move control session teardown to SDLIAPTransport disconnect.
This was referenced Jun 28, 2018
Closed
Closed
@theresalech theresalech mentioned this issue Jul 22, 2019
Closed
@yoooriii yoooriii mentioned this issue Mar 11, 2020
Merged
2 tasks
@NicoleYarroch NicoleYarroch mentioned this issue Apr 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
best practice Not a defect but something that should be improved anyway
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@joeljfischer