Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Streaming RootViewController getter & setter #1102

Merged
merged 1 commit into from
Oct 9, 2018
Merged

Fix Streaming RootViewController getter & setter #1102

merged 1 commit into from
Oct 9, 2018

Conversation

joeljfischer
Copy link
Contributor

Fixes #1100, #1101

This PR is ready for review.

Risk

This PR makes minor API changes.

Testing Plan

Smoke tests

Summary

Fix setting and getting the rootViewController for CarWindow.

Changelog

Bug Fixes
  • Fix setting and getting the rootViewController for CarWindow.

CLA

@joeljfischer joeljfischer added the bug A defect in the library label Oct 9, 2018
@joeljfischer joeljfischer added this to the 6.1.0 milestone Oct 9, 2018
@joeljfischer joeljfischer self-assigned this Oct 9, 2018
@joeljfischer joeljfischer merged commit c97fd20 into develop Oct 9, 2018
@joeljfischer joeljfischer deleted the bugfix/issue_1101_1100_streaming_rootViewController_fixes branch October 9, 2018 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicoleYarroch NicoleYarroch NicoleYarroch approved these changes

Assignees

@joeljfischer joeljfischer

Labels
bug A defect in the library
Projects
None yet
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@joeljfischer @NicoleYarroch