[SDL-0196] Support Static Icon in Screen Manager #1106
Conversation
joeljfischer
force-pushed
the
feature/issue_1062_static_icon_sdlartwork_support
branch
from
928e9b5 to
e8fc233
Compare
|
There are two failing test cases in SDLPreloadChoicesOperationSpec |
| @@ -293,7 +293,7 @@ - (void)sdl_uploadOtherStateImages { | |||
| for (SDLSoftButtonObject *object in self.softButtonObjects) { | |||
| for (SDLSoftButtonState *state in object.states) { | |||
| if ([state.name isEqualToString:object.currentState.name]) { continue; } | |||
| if (state.artwork != nil && ![self.fileManager hasUploadedFile:state.artwork]) { | |||
| if (![self sdl_artworkNeedsUpload:object.currentState.artwork]) { | |||
| [otherStatesToBeUploaded addObject:state.artwork]; | |||
There was a problem hiding this comment.
| [otherStatesToBeUploaded addObject:state.artwork]; | |
| [otherStatesToBeUploaded addObject:object.currentState.artwork]; |
There was a problem hiding this comment.
Otherwise the app crashes when inserting a nil state.artwork into the array.
There was a problem hiding this comment.
I think that's incorrect logic that will cause other state artwork to never get uploaded.
There was a problem hiding this comment.
All I know is that my app kept crashing at that point when I uploaded a soft button with a static icon image
|
The |
|
Maybe you should add static icons to the PICS in the example apps so we have an example of how to use static icons? |
…_support # Conflicts: # SmartDeviceLink/SDLChoiceSetManager.m # SmartDeviceLink/SDLSoftButtonManager.m # SmartDeviceLink/SDLTextAndGraphicManager.m
* Many fixes to artwork uploads
joeljfischer
deleted the
feature/issue_1062_static_icon_sdlartwork_support
branch
Fixes #1062
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
Unit tests and smoke tests
Summary
SDLArtworkand screen manager updated to support static icons and theSDLStaticIconNameenum.Changelog
Enhancements
SDLArtworkcan now be created with a static icon. Such artworks can be passed to theSDLScreenManagerfor use in various image slots such as soft buttons and choices.Bug Fixes
SetDisplayLayoutcausingSDLScreenManagerto break.Tasks Remaining:
CLA