Implement SDL 0173 Read Generic Network Signal Data #1374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ehicleData" and "genericNetworkData" to "getOEMCustomVehicleData"
|
@mrapitis as the proposal to revise this feature (smartdevicelink/sdl_evolution#806) has been accepted, please advise when this PR has been tested by Ford and is ready for Livio review. |
|
@smartdevicelink/ios PR is ready for review, thanks! |
joeljfischer
suggested changes
Aug 27, 2019
SmartDeviceLinkTests/RPCSpecs/ResponseSpecs/SDLUnsubscribeVehicleDataResponseSpec.m
Show resolved
Hide resolved
SmartDeviceLinkTests/RPCSpecs/ResponseSpecs/SDLUnsubscribeVehicleDataResponseSpec.m
Outdated
Show resolved
Hide resolved
SmartDeviceLinkTests/RPCSpecs/StructSpecs/SDLVehicleDataResultSpec.m
Outdated
Show resolved
Hide resolved
SmartDeviceLinkTests/RPCSpecs/StructSpecs/SDLVehicleDataResultSpec.m
Outdated
Show resolved
Hide resolved
SmartDeviceLinkTests/RPCSpecs/StructSpecs/SDLVehicleDataResultSpec.m
Outdated
Show resolved
Hide resolved
|
Also RPC changes (the new methods and such) should have documentation stating that they were introduced in SDL 6.0. |
…cleDataResponseSpec.m Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
…cleDataResponseSpec.m Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
|
@joeljfischer thanks for the feedback. Comments have been addressed, please re-review when time permits. |
joeljfischer
suggested changes
Aug 28, 2019
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
Co-Authored-By: Joel Fischer <joeljfischer@gmail.com>
|
@joeljfischer awesome, thanks again for your review. New comments have been addressed, please re-review when time permits. |
joeljfischer
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1184
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
Added new unit tests and expanded existing ones
Summary
Added RPC structs, enums as defined in the Read Generic Network Signal Data proposal.
CLA