Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for SDL protocol message version #1859

Merged

Conversation

FrankElias77
Copy link
Contributor

@FrankElias77 FrankElias77 commented Nov 24, 2020

Fixes #1837

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Unit Tests

New test added to handle property resets

Core Tests

N/A

Core version / branch / commit hash / module tested against: N/A
HMI name / version / branch / commit hash / module tested against: N/A

Summary

Fix for initial protocol version after subsequent iAP connects.

Changelog

Breaking Changes
  • N/A
Enhancements
  • N/A
Bug Fixes
  • Fix for initial protocol version after subsequent iAP connects.

Tasks Remaining:

N/A

CLA

@FrankElias77 FrankElias77 self-assigned this Nov 24, 2020
@FrankElias77 FrankElias77 added bug A defect in the library protocol Relating to the protocol layer labels Nov 24, 2020
@FrankElias77 FrankElias77 changed the title Fix protocol version Fix for SDL protocol message version Nov 24, 2020
@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #1859 (cbef832) into develop (a87a7b7) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #1859      +/-   ##
===========================================
+ Coverage    84.63%   84.66%   +0.03%     
===========================================
  Files          418      418              
  Lines        20955    20972      +17     
===========================================
+ Hits         17735    17756      +21     
+ Misses        3220     3216       -4     

@FrankElias77 FrankElias77 marked this pull request as ready for review November 24, 2020 22:32
SmartDeviceLink/private/SDLGlobals.h Outdated Show resolved Hide resolved
SmartDeviceLink/private/SDLGlobals.m Outdated Show resolved Hide resolved
SmartDeviceLink/private/SDLLifecycleProtocolHandler.m Outdated Show resolved Hide resolved
SmartDeviceLinkTests/UtilitiesSpecs/SDLGlobalsSpec.m Outdated Show resolved Hide resolved
@joeljfischer joeljfischer merged commit cd84052 into develop Dec 3, 2020
@joeljfischer joeljfischer deleted the bugfix/issue-1837-first-StartService-isnt-always-V1 branch December 3, 2020 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library protocol Relating to the protocol layer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants