SDL-0238 Keyboard Enhancements #1883

yoooriii · 2020-12-18T00:28:47Z

This PR is ready for review.

Risk

This PR makes minor API changes.

Testing Plan

I have verified that I have not introduced new warnings in this PR (or explain why below)
I have run the unit tests with this PR
I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Unit Tests

New tests:
SDLKeyboardInputMaskSpec.m
SDLKeyboardCapabilitiesSpec.m
SDLKeyboardLayoutCapabilitySpec.m
Updated tests:
SDLKeyboardEventSpec.m
SDLKeyboardLayoutSpec.m
SDLKeyboardPropertiesSpec.m
SDLWindowCapabilitySpec.m

Core Tests

List of tests performed against Core and behaviours verified
Core version / branch / commit hash / module tested against: sdl_0238_keyboard_enhancements
HMI name / version / branch / commit hash / module tested against: sdl_0238_keyboard_enhancements

Summary

Added a new keyboard layout and added new properties for keyboards supported by SDL.

Support for Numeric Keyboard.
Allow apps to mask entered characters.
Allow apps to change special characters shown on the keyboard layout.

Changelog

Breaking Changes

no breaking changes

Enhancements

no enhancements

Bug Fixes

no bug fixes

Tasks Remaining:

none

CLA

I have signed the CLA

…ed classes and methods, fix the code to compile in xcode with no issues.

codecov · 2020-12-18T00:45:20Z

Codecov Report

Merging #1883 (b2d18db) into develop (74852b5) will increase coverage by 0.06%.
The diff coverage is 94.27%.

@@             Coverage Diff             @@
##           develop    #1883      +/-   ##
===========================================
+ Coverage    84.94%   85.00%   +0.06%     
===========================================
  Files          426      428       +2     
  Lines        21383    21559     +176     
===========================================
+ Hits         18164    18327     +163     
- Misses        3219     3232      +13

…ge-build.sh script first)

…eyMaskEnabled/Disabled events.

a-prykho · 2020-12-23T09:15:16Z

@standa1-ford this PR is ready for Ford review

SmartDeviceLink/public/SDLConfigurableKeyboards.h

…iew) and update -init method to make Codecov happy.

yoooriii · 2021-01-06T10:54:20Z

Hello @standa1-ford, I have fixed your comment, could you please accept it? Thank you.

SmartDeviceLink/private/SDLRPCParameterNames.m

SmartDeviceLinkTests/RPCSpecs/StructSpecs/SDLWindowCapabilitySpec.m

standa1-ford

Looks good!

… code generator issue)

a-prykho · 2021-01-08T14:32:17Z

Dear @jordynmackool, @joeljfischer this PR is ready for Livio review

jordynmackool · 2021-01-08T15:10:57Z

@standa1-ford is looks like changes were made to the PR after your approval - please confirm this is ready for Livio review.

standa1-ford · 2021-01-08T17:35:47Z

@jordynmackool approved

jordynmackool · 2021-02-03T21:42:17Z

@yoooriii the proposal markdown file has been updated per the revisions included in the accepted with revisions review issue: Revise SDL-0238 Keyboard Enhancements.

Please make the needed updates to this PR and then tag @FrankElias77 to review when ready. Thanks!

…conflicts resolved in SDLRPCParameterNames

…treamingCapabilitySpec (it has nothing to do with the PR but it fails)

…nflicts in project.pbxproj resolved (accepted both)

…, etc

…est.

yoooriii · 2021-02-13T04:15:08Z

Hello @joeljfischer. I have fixed the comments, could you review please? Thank you.

yoooriii · 2021-02-13T05:35:21Z

Note: for some reason SDLVoiceCommandManagerSpec.m fails at random on different tests, it has nothing to do with the PR.

SmartDeviceLink/private/SDLPresentKeyboardOperation.m

…rd capability method and proper logic

…ent tests

yoooriii · 2021-02-17T16:43:57Z

Hello @joeljfischer. I have implemented the requested logic. Could you please review? Thank you.

SmartDeviceLink/private/SDLWindowCapability+ScreenManagerExtensions.h

SmartDeviceLink/private/SDLWindowCapability+ScreenManagerExtensions.m

SmartDeviceLink/private/SDLPresentKeyboardOperation.m

SmartDeviceLink/private/SDLPresentChoiceSetOperation.m

SmartDeviceLink/private/SDLWindowCapability+ScreenManagerExtensions.h

… logic to sort outgoing capabilities)

…thod -createValidKeyboardConfigurationBasedOnKeyboardCapabilitiesFromConfiguration:

yoooriii · 2021-02-18T14:17:49Z

Hello @joeljfischer. I have implemented the requested changes. Could you please review the PR? Thank you.

Note: for some reason a unit test failed in SDLVoiceCommandManagerSpec on the previous run. It has nothing to do with the PR.

joeljfischer

A few more minor items

SmartDeviceLink/private/SDLWindowCapability+ScreenManagerExtensions.m

SmartDeviceLinkTests/RPCSpecs/StructSpecs/SDLWindowCapabilitySpec.m

SmartDeviceLink/private/SDLWindowCapability+ScreenManagerExtensions.m

… couple of additional tests to cover custom keys trim logic

yoooriii · 2021-02-19T08:28:21Z

Hello @joeljfischer. I have implemented the changes from the code review. Could you please proceed? Thank you.

joeljfischer

One missed item from last time

SmartDeviceLink/private/SDLWindowCapability+ScreenManagerExtensions.m

…sions.m Co-authored-by: Joel Fischer <joeljfischer@gmail.com>

yoooriii · 2021-02-19T22:38:07Z

One missed item from last time

@joeljfischer I am sorry, I missed this one. I have commited, Could you review please? Thank you.

joeljfischer

Last minute testing & alignment caught one more issue.

SmartDeviceLink/private/SDLPresentKeyboardOperation.m

…g to SDLPresentChoiceSetOperation and add a unit test

yoooriii · 2021-02-23T16:28:47Z

Hello @joeljfischer. I have implemented the requested logic and a unit test for it. Could you please take a look? Thank you.

yoooriii added 2 commits December 18, 2020 02:25

SDL0238 'Keyboard Enhancements': implement proposal, add auto generat…

f0321a6

…ed classes and methods, fix the code to compile in xcode with no issues.

SDL0238 'Keyboard Enhancements': make new headers public

6ba9d54

yoooriii added 2 commits December 20, 2020 20:26

SDL0238 'Keyboard Enhancements': implement unit tests (pls run cartha…

1d7f7c8

…ge-build.sh script first)

SDL0238 'Keyboard Enhancements': notify SDLKeyboardDelegate of InputK…

5d52b36

…eyMaskEnabled/Disabled events.

standa1-ford reviewed Dec 29, 2020

View reviewed changes

SmartDeviceLink/public/SDLConfigurableKeyboards.h Outdated Show resolved Hide resolved

SDL0238 'Keyboard Enhancements': Update a comment (as proposed in rev…

4564dcb

…iew) and update -init method to make Codecov happy.

yoooriii marked this pull request as ready for review January 6, 2021 11:10

standa1-ford reviewed Jan 7, 2021

View reviewed changes

SmartDeviceLink/private/SDLRPCParameterNames.m Outdated Show resolved Hide resolved

standa1-ford reviewed Jan 7, 2021

View reviewed changes

SmartDeviceLinkTests/RPCSpecs/StructSpecs/SDLWindowCapabilitySpec.m Outdated Show resolved Hide resolved

standa1-ford approved these changes Jan 7, 2021

View reviewed changes

SDL0238 'Keyboard Enhancements': fix wrong parameter name (upper case…

6d73461

… code generator issue)

standa1-ford approved these changes Jan 8, 2021

View reviewed changes

joeljfischer added manager-screen Relating to the manager layer - screen managers proposal Accepted SDL Evolution Proposal rpc Relating to the RPC layer labels Jan 25, 2021

yoooriii added 7 commits February 5, 2021 21:54

SDL0238 'Keyboard Enhancements': Merge branch 'develop' into this. 2 …

7eb10d3

…conflicts resolved in SDLRPCParameterNames

SDL0238 'Keyboard Enhancements': fix a mistake in unit test SDLVideoS…

d64e7b2

…treamingCapabilitySpec (it has nothing to do with the PR but it fails)

SDL0238 'Keyboard Enhancements': Merge branch 'develop' into this. Co…

90e6f5e

…nflicts in project.pbxproj resolved (accepted both)

SDL0238 'Keyboard Enhancements r2': implement, add new classes, enums…

6fe8d4f

…, etc

SDL0238 'Keyboard Enhancements r2': implement unit tests

392b961

SDL0238 'Keyboard Enhancements r2': fix SDLWindowCapability and its t…

d734ed1

…est.

SDL0238 'Keyboard Enhancements r2': add missing tests

9653873

yoooriii requested a review from joeljfischer February 13, 2021 04:14

joeljfischer suggested changes Feb 15, 2021

View reviewed changes

SmartDeviceLink/private/SDLPresentKeyboardOperation.m Show resolved Hide resolved

yoooriii added 2 commits February 17, 2021 18:14

SDL0238 'Keyboard Enhancements/r3': implement filter supported keyboa…

a49e4b7

…rd capability method and proper logic

SDL0238 'Keyboard Enhancements/r3': update keyboard capability depend…

9040b32

…ent tests

yoooriii requested a review from joeljfischer February 17, 2021 16:43

joeljfischer suggested changes Feb 17, 2021

View reviewed changes

yoooriii added 2 commits February 18, 2021 11:12

SDL0238 'Keyboard Enhancements/r3': apply review comments (refine the…

4e90a13

… logic to sort outgoing capabilities)

SDL0238 'Keyboard Enhancements/r3': implement test set for the new me…

8bc694f

…thod -createValidKeyboardConfigurationBasedOnKeyboardCapabilitiesFromConfiguration:

yoooriii requested a review from joeljfischer February 18, 2021 14:15

joeljfischer suggested changes Feb 18, 2021

View reviewed changes

SDL0238 'Keyboard Enhancements/r4': apply code review comments, add a…

6d598d1

… couple of additional tests to cover custom keys trim logic

yoooriii requested a review from joeljfischer February 19, 2021 08:27

joeljfischer suggested changes Feb 19, 2021

View reviewed changes

SmartDeviceLink/private/SDLWindowCapability+ScreenManagerExtensions.m Outdated Show resolved Hide resolved

yoooriii and others added 2 commits February 20, 2021 00:30

SDL0238 'Keyboard Enhancements/r4': add one more lost comment

9cab7e9

Update SmartDeviceLink/private/SDLWindowCapability+ScreenManagerExten…

575f2b4

…sions.m Co-authored-by: Joel Fischer <joeljfischer@gmail.com>

yoooriii requested a review from joeljfischer February 19, 2021 22:36

joeljfischer suggested changes Feb 22, 2021

View reviewed changes

SmartDeviceLink/private/SDLPresentKeyboardOperation.m Show resolved Hide resolved

SDL0238 'Keyboard Enhancements/r4': add keyboard notification handlin…

015b6b5

…g to SDLPresentChoiceSetOperation and add a unit test

yoooriii requested a review from joeljfischer February 23, 2021 16:27

joeljfischer approved these changes Feb 24, 2021

View reviewed changes

joeljfischer merged commit c9db35d into smartdevicelink:develop Feb 24, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SDL-0238 Keyboard Enhancements #1883

SDL-0238 Keyboard Enhancements #1883

yoooriii commented Dec 18, 2020 •

edited

Loading

codecov bot commented Dec 18, 2020 •

edited

Loading

a-prykho commented Dec 23, 2020

yoooriii commented Jan 6, 2021

standa1-ford left a comment

a-prykho commented Jan 8, 2021

jordynmackool commented Jan 8, 2021

standa1-ford commented Jan 8, 2021

jordynmackool commented Feb 3, 2021

yoooriii commented Feb 13, 2021

yoooriii commented Feb 13, 2021

yoooriii commented Feb 17, 2021

yoooriii commented Feb 18, 2021

joeljfischer left a comment

yoooriii commented Feb 19, 2021

joeljfischer left a comment

yoooriii commented Feb 19, 2021

joeljfischer left a comment

yoooriii commented Feb 23, 2021

SDL-0238 Keyboard Enhancements #1883

SDL-0238 Keyboard Enhancements #1883

Conversation

yoooriii commented Dec 18, 2020 • edited Loading

Risk

Testing Plan

Unit Tests

Core Tests

Summary

Changelog

Breaking Changes

Enhancements

Bug Fixes

Tasks Remaining:

CLA

codecov bot commented Dec 18, 2020 • edited Loading

Codecov Report

a-prykho commented Dec 23, 2020

yoooriii commented Jan 6, 2021

standa1-ford left a comment

Choose a reason for hiding this comment

a-prykho commented Jan 8, 2021

jordynmackool commented Jan 8, 2021

standa1-ford commented Jan 8, 2021

jordynmackool commented Feb 3, 2021

yoooriii commented Feb 13, 2021

yoooriii commented Feb 13, 2021

yoooriii commented Feb 17, 2021

yoooriii commented Feb 18, 2021

joeljfischer left a comment

Choose a reason for hiding this comment

yoooriii commented Feb 19, 2021

joeljfischer left a comment

Choose a reason for hiding this comment

yoooriii commented Feb 19, 2021

joeljfischer left a comment

Choose a reason for hiding this comment

yoooriii commented Feb 23, 2021

yoooriii commented Dec 18, 2020 •

edited

Loading

codecov bot commented Dec 18, 2020 •

edited

Loading