Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the timeout on some tests to fix CI fails #1930

Merged
merged 14 commits into from
Mar 10, 2021

Conversation

joeljfischer
Copy link
Contributor

Fixes #1929

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Unit Tests

Unit test fixes, no additions or removals

Core Tests

n/a - unit test fixes only

Core version / branch / commit hash / module tested against: n/a
HMI name / version / branch / commit hash / module tested against: n/a

Summary

Fixed unit test timeouts to increase reliability

Changelog

Bug Fixes
  • Unit test fixes to increase reliability on CI

Tasks Remaining:

n/a

CLA

@joeljfischer joeljfischer added the testing Relating to unit testing or smoke testing label Mar 3, 2021
@joeljfischer joeljfischer self-assigned this Mar 3, 2021
@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #1930 (a0388dc) into develop (c1fd017) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1930   +/-   ##
========================================
  Coverage    83.42%   83.42%           
========================================
  Files          441      441           
  Lines        22601    22601           
========================================
+ Hits         18854    18855    +1     
+ Misses        3747     3746    -1     

@NicoleYarroch NicoleYarroch linked an issue Mar 4, 2021 that may be closed by this pull request
Copy link
Contributor

@NicoleYarroch NicoleYarroch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One change requested.

Copy link
Contributor

@NicoleYarroch NicoleYarroch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like some tests are failing in the SDLSoftButtonManagerSpec on the remote: https://github.com/smartdevicelink/sdl_ios/pull/1930/checks?check_run_id=2042800017
I did have it fail once in the same place when running the tests locally but couldn't reproduce after running the tests a few times.

@NicoleYarroch NicoleYarroch merged commit 52a819e into develop Mar 10, 2021
@NicoleYarroch NicoleYarroch deleted the bugfix/issue-1929-failing-ci-tests branch March 10, 2021 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Relating to unit testing or smoke testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Sometimes Failing CI Tests
2 participants