-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase the timeout on some tests to fix CI fails #1930
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #1930 +/- ##
========================================
Coverage 83.42% 83.42%
========================================
Files 441 441
Lines 22601 22601
========================================
+ Hits 18854 18855 +1
+ Misses 3747 3746 -1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One change requested.
SmartDeviceLinkTests/ProxySpecs/SDLSecondaryTransportManagerSpec.m
Outdated
Show resolved
Hide resolved
SmartDeviceLinkTests/ProxySpecs/SDLSecondaryTransportManagerSpec.m
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like some tests are failing in the SDLSoftButtonManagerSpec
on the remote: https://github.com/smartdevicelink/sdl_ios/pull/1930/checks?check_run_id=2042800017
I did have it fail once in the same place when running the tests locally but couldn't reproduce after running the tests a few times.
Fixes #1929
Risk
This PR makes no API changes.
Testing Plan
Unit Tests
Unit test fixes, no additions or removals
Core Tests
n/a - unit test fixes only
Core version / branch / commit hash / module tested against: n/a
HMI name / version / branch / commit hash / module tested against: n/a
Summary
Fixed unit test timeouts to increase reliability
Changelog
Bug Fixes
Tasks Remaining:
n/a
CLA