Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated SDLMenuCell params order #1932

Merged

Conversation

FrankElias77
Copy link
Contributor

Fixes #1931

Risk

This PR makes minor API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Unit Tests

Updated test files that implements SDLMenuCell

Core Tests

N/A

Core version / branch / commit hash / module tested against: N/A
HMI name / version / branch / commit hash / module tested against: N/A

Summary

Reordered SDLMenuCell params(secondaryText, tertiaryText, secondaryArtwork)

Changelog

Breaking Changes
  • Reordered SDLMenuCell params(secondaryText, tertiaryText, secondaryArtwork)
Enhancements
  • N/A
Bug Fixes
  • N/A

Tasks Remaining:

N/A

CLA

@FrankElias77 FrankElias77 added the best practice Not a defect but something that should be improved anyway label Mar 3, 2021
@FrankElias77 FrankElias77 self-assigned this Mar 3, 2021
@FrankElias77 FrankElias77 marked this pull request as ready for review March 3, 2021 17:32
Copy link
Contributor

@joeljfischer joeljfischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change needed

SmartDeviceLink/public/SDLMenuCell.h Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 3, 2021

Codecov Report

Merging #1932 (bab5e06) into develop (130b790) will increase coverage by 0.37%.
The diff coverage is 98.23%.

@@             Coverage Diff             @@
##           develop    #1932      +/-   ##
===========================================
+ Coverage    85.02%   85.40%   +0.37%     
===========================================
  Files          429      434       +5     
  Lines        21640    22091     +451     
===========================================
+ Hits         18400    18866     +466     
+ Misses        3240     3225      -15     

@joeljfischer joeljfischer merged commit ee70ad1 into develop Mar 4, 2021
@joeljfischer joeljfischer deleted the bugfix/issue-1931-update-SDLMenuCell-params-order branch March 4, 2021 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
best practice Not a defect but something that should be improved anyway
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants