Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes related to auxillary #1939

Merged

Conversation

FrankElias77
Copy link
Contributor

Fixes #1938

Risk

This PR makes minor API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Unit Tests

N/A

Core Tests

N/A

Core version / branch / commit hash / module tested against: Branch develop
HMI name / version / branch / commit hash / module tested against: N/A

Summary

Fixed spelling of auxillary in SDLStaticIconName

Changelog

Breaking Changes
  • N/A
Enhancements
  • N/A
Bug Fixes
  • N/A

Tasks Remaining:

N/A

CLA

@FrankElias77 FrankElias77 added the bug A defect in the library label Mar 9, 2021
@FrankElias77 FrankElias77 self-assigned this Mar 9, 2021
@codecov
Copy link

codecov bot commented Mar 9, 2021

Codecov Report

Merging #1939 (6480d19) into develop (04a551f) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1939   +/-   ##
========================================
  Coverage    85.46%   85.47%           
========================================
  Files          436      436           
  Lines        22156    22156           
========================================
+ Hits         18935    18937    +2     
+ Misses        3221     3219    -2     

@FrankElias77 FrankElias77 marked this pull request as ready for review March 9, 2021 15:10
@NicoleYarroch NicoleYarroch linked an issue Mar 9, 2021 that may be closed by this pull request
Copy link
Contributor

@NicoleYarroch NicoleYarroch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested a deprecated message be added.

SmartDeviceLink/public/SDLStaticIconName.h Outdated Show resolved Hide resolved
Copy link
Contributor

@NicoleYarroch NicoleYarroch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One little thing I missed in the first review.

SmartDeviceLink/public/SDLStaticIconName.h Outdated Show resolved Hide resolved
@NicoleYarroch NicoleYarroch merged commit e44d325 into develop Mar 12, 2021
@NicoleYarroch NicoleYarroch deleted the bugfix/issue-1938-fix-spelling-in-SDLStaticIconName branch March 12, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A defect in the library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Spelling of auxillary in SDLStaticIconName
2 participants