-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support TLS max size when encrypted #1955
Support TLS max size when encrypted #1955
Conversation
Codecov Report
@@ Coverage Diff @@
## hotfix/7.1.1 #1955 +/- ##
=================================================
- Coverage 83.69% 14.21% -69.49%
=================================================
Files 441 441
Lines 22564 22577 +13
=================================================
- Hits 18885 3209 -15676
- Misses 3679 19368 +15689 |
* Update naming for clarity * Update comments * Update tests
…ti-frame # Conflicts: # SmartDeviceLink/private/SDLProtocol.m # SmartDeviceLinkTests/ProtocolSpecs/MessageSpecs/SDLProtocolSpec.m
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small changes requested
Fixes #1954
Risk
This PR makes no API changes.
Testing Plan
Unit Tests
Tests were added for sending encryption RPCs when encryption is ready and not ready.
Core Tests
Core version / branch / commit hash / module tested against: Core v7.1.0
HMI name / version / branch / commit hash / module tested against: Generic HMI v0.10.0, sdl_hmi v5.5.0
Summary
Updates encryption to only send a max of 16384 bytes per packet due to TLS limitations when connected over encryption.
Changelog
Bug Fixes
Tasks Remaining:
CLA