Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue - 2118 | Fix Unit Tests dependencies using pods #2120

Closed

Conversation

FrankElias77
Copy link
Contributor

@FrankElias77 FrankElias77 commented Jun 15, 2023

Fixes #2118

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Unit Tests

No unit tests were added, only changed how the frameworks are imported into our spec files.

Core Tests

N/A

Core version / branch / commit hash / module tested against: N/A
HMI name / version / branch / commit hash / module tested against: N/A

Summary

This PR changes the dependency manager from Carthage to Cocoapods. In this process I have removed all integrations and references related to Carthage and re-installed the testing dependencies using Cocoapods.

Changelog

Breaking Changes
  • N/A
Enhancements
  • N/A
Bug Fixes
  • With this update, the sdl unit tests are working with XCode 14.3.1 and also in the github actions

Tasks Remaining:

  • Optional: Fix RPC Generator tests

CLA

@FrankElias77 FrankElias77 added the testing Relating to unit testing or smoke testing label Jun 15, 2023
@FrankElias77 FrankElias77 self-assigned this Jun 15, 2023
@FrankElias77 FrankElias77 changed the title Bugfix/issue 2118 update testing dependencies Issue - 2118 | Fix Unit Tests dependencies Jun 15, 2023
@FrankElias77 FrankElias77 changed the title Issue - 2118 | Fix Unit Tests dependencies Issue - 2118 | Fix Unit Tests dependencies using pods Jun 15, 2023
@FrankElias77 FrankElias77 marked this pull request as ready for review June 19, 2023 13:31
@FrankElias77 FrankElias77 requested a review from tstrayer June 19, 2023 15:38
@FrankElias77 FrankElias77 added the HOLD TO MERGE Hold PR to merge label Jun 21, 2023
@jordynmackool
Copy link
Contributor

Closing as we are using #2119 instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HOLD TO MERGE Hold PR to merge testing Relating to unit testing or smoke testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Unit Tests related dependencies
2 participants