App Launching for 4.0 #99

joeljfischer · 2015-03-09T20:55:03Z

Based on #45, refactored for new project structure

🐱 Not Ready to Merge 🐱

Summary

This PR will involve several pieces to allow an iOS application to track available applications on the users phone that can be launched with SmartDeviceLink. This will involve 4 major pieces.

Head Unit tracking of the foregrounded application on a user's phone.
Head Unit requested querying of a server URL to retrieve a list of applications that are SDL compatible.
Parsing the response from the server, and determining which apps installed on the user's phone can be launched, and sending the filtered response to the HU.
Responding to a request from the HU to launch a specific app, and launching it.

In Depth

Tracking Foregrounded Application

The SDL Proxy object, upon opening a connection, will poll the application for its state, and send that across. It will also immediately set up observers on application state changes. Upon firing of those observers, it will recheck the application for its state, and push a new notification to the HU.

This PR also introduces the ability to send notifications from the Mobile API (issue #34). This is required because application state changes are sent via a pre-existing RPC Notification that was previously only sent from the HU, onHMIStatus. FULL is equivalent to foreground, LIMITED is equivalent to background.

Query Apps Server HTTP Request

The HU will request, via a OnSystemRequest, that the mobile device retrieve an application list from the server. The application may (this has not yet been determined) cache the response for a specified period.

Query Apps Filter Installed Applications

The server will respond with a set response, described here which will be parsed by the library. The library will then run a system call to determine which apps are installed on the phone. The library will then filter the list passed by the server so that only installed apps are represented, and forward it on to the HU.

Launch App

The HU will send an OnSystemRequest with a URL field that contains the URL scheme of the app they wish to launch to the foregrounded application. The library running in that application will then attempt to launch the application specified by the url scheme passed in. This will, of course, foreground that application, and background the application making the call.

TODO

General

Make sure the proxy can handle being at v4
Refactor SDLRPCNotification, SDLRPCMessage, etc., so that it sets it's messageType correctly. ~~See PR Feature/2.3.1 #67~~ See If an SDLRPCMessage object is initialized using initWithName, the messageType is always set to "request" #64

Tracking Foreground State

Track Application State
Add the ability to send RPCNotifications (by sending any type of RPCMessage)
Send an OnHMIStatus notification to connected HU when application state changes
Remove app state observers when session closes
Properly log and handle errors

Query Apps Server HTTP Request

Create new SystemRequest enum type for Query Apps
Capture OnSystemRequests for Query Apps and Launch App commands
Make a query apps web call to the server specified in the OnSystemRequest to retrieve a list of URLs
Parse the response from the server, determine applications to be checked
Properly log and handle errors
Determine if NSURLSessionUploadTask should be NSURLSessionDataTask

Query App Filter Installed Applications

Test each application to see if it's installed on the phone
Filter the response from the server based on which apps are installed on the phone
Send the filtered response to the Head Unit
Properly log and handle errors

Launch App

Create new SystemRequest enum type for Launch App
Parse a Launch App OnSystemRequest
Open the specified application from a Launch App OnSystemRequest
Properly log and handle errors

Other

Test changes to query apps did not adversely affect Policy Server requests
Refactor into new develop project layout

Based on #45

joeljfischer · 2015-03-10T21:21:10Z

This fixes #64

hugh22 · 2015-04-22T18:36:31Z

SmartDeviceLink-iOS/SmartDeviceLink/SDLProtocol.m

        _version = 1;
        _messageID = 0;
        _sessionID = 0;
        _recieveQueue = dispatch_queue_create("com.sdl.recieve", DISPATCH_QUEUE_SERIAL);
        _sendQueue = dispatch_queue_create("com.sdl.send.defaultpriority", DISPATCH_QUEUE_SERIAL);
        prioritizedCollection = [SDLPrioritizedObjectCollection new];
-
+        


Please get rid of these.

If I had to guess, I would say they were automatic Xcode changes in response to spacing inconsistencies? I can't really tell what happened here.

joeljfischer · 2015-04-22T19:20:27Z

SmartDeviceLink-iOS/SmartDeviceLink/SDLProxy.m

+        return nil;
+    }
+
+    return JSONDicationary;


Misspelling

Conflicts: SmartDeviceLink-iOS/SmartDeviceLink-iOS.xcodeproj/project.pbxproj SmartDeviceLink-iOS/SmartDeviceLink/SDLAbstractProtocol.m SmartDeviceLink-iOS/SmartDeviceLink/SDLDimension.h SmartDeviceLink-iOS/SmartDeviceLink/SDLProtocol.m SmartDeviceLink-iOS/SmartDeviceLink/SDLProtocolHeader.m SmartDeviceLink-iOS/SmartDeviceLink/SDLProxy.m SmartDeviceLink-iOS/SmartDeviceLink/SDLRPCMessage.m SmartDeviceLink-iOS/SmartDeviceLink/SDLRPCMessageType.h SmartDeviceLink-iOS/SmartDeviceLink/SDLRPCMessageType.m SmartDeviceLink-iOS/SmartDeviceLink/SDLRequestType.h SmartDeviceLink-iOS/SmartDeviceLink/SDLRequestType.m SmartDeviceLink-iOS/SmartDeviceLink/SDLV2ProtocolHeader.h SmartDeviceLink-iOS/SmartDeviceLink/SDLV2ProtocolHeader.m

Fix 'task' in SDLProxy being captured by block when it wasn't initialized

joeljfischer · 2015-04-24T19:59:13Z

@hugh22 I merged in the current develop code to this branch, which appears to make following along with the code changes much easier. I'm pretty confident that the merge went well, but there were a number of errors to be resolved so just keep that in mind as well.

Fix a bug in TCPCallback to no longer attempt to parse zero length data

Conflicts: SmartDeviceLink-iOS/SmartDeviceLink/SDLRPCMessageType.h

Check for known message types, fail on unknown message types

joeljfischer · 2015-05-13T15:25:25Z

@hugh22 If you could take another look and see if your issues are resolved, that would be great!

hugh22 · 2015-05-13T18:55:20Z

Looks good to me.

Conflicts: SmartDeviceLink-iOS/SmartDeviceLink/SDLV2ProtocolHeader.h

App Launching refactored for new project structure

0343e24

Based on #45

joeljfischer mentioned this pull request Mar 9, 2015

[WIP] Application Launching (SDL 4.0) #45

Closed

23 tasks

Fixed several framework imports

1a2e94e

joeljfischer added enhancement labels Mar 9, 2015

Joel Fischer added 2 commits March 9, 2015 17:11

Fixes #64

bed7ec7

Remove unnecessary __block tag

0c1365b

joeljfischer added the REVIEW - scheduled label Mar 10, 2015

joeljfischer changed the title ~~[WIP] App Launching for 4.0~~ App Launching for 4.0 Mar 17, 2015

joeljfischer mentioned this pull request Mar 27, 2015

4.0 RPC updates #146

Closed

16 tasks

joeljfischer added this to the 4.0.0 milestone Mar 30, 2015

joeljfischer assigned hugh22 Mar 30, 2015

Improved comments

3ea4382

hugh22 reviewed Apr 22, 2015
View reviewed changes

Remove some errant newlines in SDLProtocol

b729b9d

joeljfischer reviewed Apr 22, 2015
View reviewed changes

SmartDeviceLink-iOS/SmartDeviceLink/SDLProxy.m

return nil;

}

return JSONDicationary;

Copy link

Contributor Author

joeljfischer Apr 22, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Misspelling

Joel Fischer added 3 commits April 24, 2015 15:45

Fix uninitialized variable captured by block

fc708af

Fix 'task' in SDLProxy being captured by block when it wasn't initialized

Fix misspelling of 'dictionary'

3a7f15c

Joel Fischer added 4 commits May 5, 2015 11:19

Change version dependent code to fail faster

b300cf5

Fix a bug in TCPCallback to no longer attempt to parse zero length data

Merge branch 'develop' into feature/app_launching

2dc2a90

Conflicts: SmartDeviceLink-iOS/SmartDeviceLink/SDLRPCMessageType.h

Fix some errant instancetype changes in copyWithZone: methods

060929d

Fix messagePayload not being set

d5d9075

Joel Fischer added 4 commits May 8, 2015 11:28

Additional failure check when sending an RPC

a68af41

Check for known message types, fail on unknown message types

Fix documentation warnings

03767d6

Fixed issue preventing RPC messages from being properly serialized

a2c698a

Merge branch 'develop' into feature/app_launching

7cf6fb7

Merge branch 'develop' into feature/app_launching

d4339d9

Conflicts: SmartDeviceLink-iOS/SmartDeviceLink/SDLV2ProtocolHeader.h

joeljfischer added REVIEW - accepted and removed REVIEW - scheduled labels May 19, 2015

joeljfischer merged commit d4339d9 into develop May 19, 2015

joeljfischer deleted the feature/app_launching branch May 19, 2015 20:16

joeljfischer mentioned this pull request Jul 9, 2015

[WIP] ALM for iOS #169

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

App Launching for 4.0 #99

App Launching for 4.0 #99

joeljfischer commented Mar 9, 2015

joeljfischer commented Mar 10, 2015

hugh22 Apr 22, 2015

joeljfischer Apr 22, 2015

joeljfischer Apr 22, 2015

joeljfischer commented Apr 24, 2015

joeljfischer commented May 13, 2015

hugh22 commented May 13, 2015

App Launching for 4.0 #99

App Launching for 4.0 #99

Conversation

joeljfischer commented Mar 9, 2015

Summary

In Depth

Tracking Foregrounded Application

Query Apps Server HTTP Request

Query Apps Filter Installed Applications

Launch App

TODO

General

Tracking Foreground State

Query Apps Server HTTP Request

Query App Filter Installed Applications

Launch App

Other

joeljfischer commented Mar 10, 2015

hugh22 Apr 22, 2015

Choose a reason for hiding this comment

joeljfischer Apr 22, 2015

Choose a reason for hiding this comment

joeljfischer Apr 22, 2015

Choose a reason for hiding this comment

joeljfischer commented Apr 24, 2015

joeljfischer commented May 13, 2015

hugh22 commented May 13, 2015