Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDL 0177] Alert icon #1112

Merged
merged 5 commits into from
Jul 23, 2019
Merged

[SDL 0177] Alert icon #1112

merged 5 commits into from
Jul 23, 2019

Conversation

bilal-alsharifi
Copy link
Contributor

@bilal-alsharifi bilal-alsharifi commented Jul 16, 2019

Fixes #795

This PR is ready for review.

Risk

This PR makes minor API changes.

Testing Plan

Unit tests have been updated to test the new alertIcon param

Summary

  • Add new alertIcon param to the alert RPC

CLA

@codecov-io
Copy link

codecov-io commented Jul 16, 2019

Codecov Report

Merging #1112 into develop will decrease coverage by 2.14%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1112      +/-   ##
=============================================
- Coverage       46.8%   44.66%   -2.15%     
- Complexity      4015     4089      +74     
=============================================
  Files            453      455       +2     
  Lines          22156    23672    +1516     
  Branches        2513     2745     +232     
=============================================
+ Hits           10371    10572     +201     
- Misses         11174    12481    +1307     
- Partials         611      619       +8
Impacted Files Coverage Δ Complexity Δ
...main/java/com/smartdevicelink/proxy/rpc/Alert.java 100% <100%> (ø) 20 <2> (+2) ⬆️
...martdevicelink/proxy/rpc/enums/ImageFieldName.java 100% <100%> (ø) 2 <0> (ø) ⬇️
...smartdevicelink/encoder/VirtualDisplayEncoder.java 24.43% <0%> (-4.55%) 8% <0%> (ø)
...ers/screen/choiceset/PresentKeyboardOperation.java 13.9% <0%> (-0.99%) 3% <0%> (+1%)
...n/java/com/smartdevicelink/proxy/SdlProxyBase.java 7.54% <0%> (-0.87%) 37% <0%> (+10%)
...java/com/smartdevicelink/managers/ProxyBridge.java 3.22% <0%> (-0.84%) 2% <0%> (ø)
...com/smartdevicelink/protocol/enums/FunctionID.java 93.79% <0%> (-0.01%) 16% <0%> (+4%)
...om/smartdevicelink/proxy/rpc/enums/ButtonName.java 100% <0%> (ø) 27% <0%> (+13%) ⬆️
...om/smartdevicelink/proxy/rpc/MediaServiceData.java 100% <0%> (ø) 49% <0%> (+23%) ⬆️
...m/smartdevicelink/proxy/rpc/PublishAppService.java 100% <0%> (ø) 7% <0%> (+2%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95b0b1b...0661657. Read the comment docs.

@bilal-alsharifi bilal-alsharifi changed the title WIP - [SDL 0177] Alert icon [SDL 0177] Alert icon Jul 16, 2019
@bilal-alsharifi bilal-alsharifi self-assigned this Jul 17, 2019
@BrettyWhite BrettyWhite merged commit 30b3ba4 into develop Jul 23, 2019
@BrettyWhite BrettyWhite deleted the feature/issue_795 branch July 23, 2019 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants