Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Issue 1125 Show OEM Logo Lockscreen #1130

Merged
merged 1 commit into from
Jul 25, 2019

Conversation

BrettyWhite
Copy link
Contributor

Fixes #1125

This PR is ready for review.

Risk

This PR makes minor API changes.

Testing Plan

Smoke testing was performed against the develop branch of core on an ubuntu VM

Summary

Change the default value of showDeviceLogo in the LockscreenConfig from false to true to match iOS

CLA

@codecov-io
Copy link

codecov-io commented Jul 24, 2019

Codecov Report

Merging #1130 into develop will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1130      +/-   ##
=============================================
+ Coverage      46.89%   46.92%   +0.03%     
+ Complexity      4048     4047       -1     
=============================================
  Files            457      457              
  Lines          22286    22286              
  Branches        2522     2522              
=============================================
+ Hits           10450    10458       +8     
+ Misses         11223    11212      -11     
- Partials         613      616       +3
Impacted Files Coverage Δ Complexity Δ
...vicelink/managers/lockscreen/LockScreenConfig.java 100% <100%> (ø) 11 <0> (ø) ⬇️
...icelink/managers/lockscreen/LockScreenManager.java 32.43% <0%> (ø) 5% <0%> (-1%) ⬇️
...smartdevicelink/encoder/VirtualDisplayEncoder.java 28.97% <0%> (+4.54%) 8% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30b3ba4...3a56f3b. Read the comment docs.

@bilal-alsharifi bilal-alsharifi merged commit cec5c75 into develop Jul 25, 2019
@bilal-alsharifi bilal-alsharifi deleted the feature/lockscreen_default branch July 25, 2019 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants