LockScreen Changes #1153
Merged
LockScreen Changes #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Codecov Report
@@ Coverage Diff @@
## develop #1153 +/- ##
=============================================
- Coverage 46.8% 44.56% -2.24%
- Complexity 4070 4439 +369
=============================================
Files 459 470 +11
Lines 22458 26562 +4104
Branches 2553 3611 +1058
=============================================
+ Hits 10512 11838 +1326
- Misses 11318 13970 +2652
- Partials 628 754 +126
Continue to review full report at Codecov.
|
| * | ||
| * <li> displayMode - Describes when the lock screen will be displayed. Defaults to `DISPLAY_MODE_REQUIRED_ONLY`.</li> | ||
| * | ||
| * <li> enableDismissGesture - If YES, then the lock screen can be dismissed with a downward swipe on compatible head units. |
There was a problem hiding this comment.
can we replace YES with true in the javadoc in this file?
| @@ -279,7 +283,7 @@ private void launchLockScreenActivity(){ | |||
| context.get().registerReceiver(mLockscreenDismissedReceiver, new IntentFilter(SDLLockScreenActivity.KEY_LOCKSCREEN_DISMISSED)); | |||
There was a problem hiding this comment.
Wouldnt that potentially register the receiver multiple times?
| @@ -99,6 +97,14 @@ public LockScreenManager(LockScreenConfig lockScreenConfig, Context context, ISd | |||
| customView = lockScreenConfig.getCustomView(); | |||
| lockScreenEnabled = lockScreenConfig.isEnabled(); | |||
| deviceLogoEnabled = lockScreenConfig.isDeviceLogoEnabled(); | |||
| displayMode = lockScreenConfig.getDisplayMode(); | |||
There was a problem hiding this comment.
When the display mode is set to DISPLAY_MODE_ALWAYS, the lock screen cannot be dismissed even if enableDismissGesture=true. not sure if that is intentional or a bug.
bilal-alsharifi
approved these changes
Aug 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #934
This PR is ready for review.
Risk
This PR makes minor API changes.
Testing Plan
Smoke tests and Unit tests
Summary
Add in a new IntDef Enum for lock screen DisplayModes, add in the ability to not allow lock screen dismissal
CLA