Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move menuLayoutsAvailable to WindowCapability #1171

Merged
merged 1 commit into from
Oct 3, 2019

Conversation

bilal-alsharifi
Copy link
Contributor

@bilal-alsharifi bilal-alsharifi commented Sep 13, 2019

Fixes #1076

This PR is ready for review.

Summary

This PR move menuLayoutsAvailable from DisplayCapabilities to WindowCapability as mentioned in the proposal.

CLA

@codecov-io
Copy link

Codecov Report

Merging #1171 into develop will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1171      +/-   ##
=============================================
+ Coverage      47.45%   47.49%   +0.03%     
  Complexity      4317     4317              
=============================================
  Files            481      481              
  Lines          23235    23235              
  Branches        2622     2622              
=============================================
+ Hits           11027    11035       +8     
+ Misses         11534    11524      -10     
- Partials         674      676       +2
Impacted Files Coverage Δ Complexity Δ
...smartdevicelink/proxy/rpc/DisplayCapabilities.java 73.91% <ø> (-1.6%) 20 <0> (-2)
...tdevicelink/managers/screen/BaseScreenManager.java 67.64% <ø> (ø) 45 <0> (ø) ⬇️
...om/smartdevicelink/proxy/rpc/WindowCapability.java 100% <100%> (ø) 20 <2> (+2) ⬆️
...smartdevicelink/encoder/VirtualDisplayEncoder.java 28.97% <0%> (+4.54%) 8% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c5d2e93...b75359c. Read the comment docs.

@BrettyWhite BrettyWhite merged commit e71879a into develop Oct 3, 2019
@BrettyWhite BrettyWhite deleted the move_menuLayoutsAvailable branch October 3, 2019 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants