Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update current screen data in T&G manager with template config #1834

Merged
merged 5 commits into from
Sep 21, 2022

Conversation

JulianKast
Copy link
Contributor

@JulianKast JulianKast commented Sep 16, 2022

Fixes #1833

This PR is [ready] for review.

Risk

This PR makes [no] API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).
  • I have tested Android, Java SE, and Java EE

Unit Tests

I updated existing unit test in TextAndGraphicUpdateOperationTest

Core Tests

Tested updating the template and check currentScreenData in BaseTextAndGraphicManager after the update.

Core version / branch / commit hash / module tested against: Manticore
HMI name / version / branch / commit hash / module tested against: Manticore

Summary

This PR adds a missing check inTextAndGraphicUpdateOperation that would check for a template config after an update and add that to currentScreenData for the TextAndGraphicManager.

Changelog

Bug Fixes
  • Adds a missing check inTextAndGraphicUpdateOperation that would check for a template config after an update and add that to currentScreenData for the TextAndGraphicManager.

CLA

@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Merging #1834 (368fb92) into develop (44b38cb) will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #1834      +/-   ##
=============================================
+ Coverage      54.02%   54.05%   +0.02%     
- Complexity      5533     5537       +4     
=============================================
  Files            562      562              
  Lines          25862    25864       +2     
  Branches        3411     3412       +1     
=============================================
+ Hits           13972    13980       +8     
+ Misses         10610    10605       -5     
+ Partials        1280     1279       -1     
Impacted Files Coverage Δ
...managers/screen/TextAndGraphicUpdateOperation.java 70.88% <100.00%> (+0.65%) ⬆️
...rtdevicelink/streaming/video/SdlRemoteDisplay.java 51.21% <0.00%> (+1.21%) ⬆️
...agers/screen/menu/VoiceCommandUpdateOperation.java 78.74% <0.00%> (+2.36%) ⬆️

@ChloeMJM
Copy link
Contributor

Tested on Manticore and everything updates appropriately. Approved.

@ChloeMJM ChloeMJM self-requested a review September 20, 2022 18:27
# Conflicts:
#	android/sdl_android/src/androidTest/java/com/smartdevicelink/managers/screen/TextAndGraphicUpdateOperationTest.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants