Refactor vector to list

[anildahiya]

No description provided.

[mikeburke106]

I will review in more detail, but I'm guessing this change will break the library due to reflection in the JsonRPCMarshaller:

public static JSONObject serializeHashtable(Hashtable<String, Object> hash) throws JSONException{
    JSONObject obj = new JSONObject();
    Iterator<String> hashKeyIterator = hash.keySet().iterator();
    while (hashKeyIterator.hasNext()){
        String key = (String) hashKeyIterator.next();
        Object value = hash.get(key);
        if (value instanceof RPCStruct) {
            obj.put(key, ((RPCStruct) value).serializeJSON());
        } else if (value instanceof Vector<?>) {
            obj.put(key, serializeVector((Vector) value));
        } else if (value instanceof Hashtable) {
            obj.put(key, serializeHashtable((Hashtable)value));
        } else {
            obj.put(key, value);
        }
    }
    return obj;
}

This method is performing reflection, looking for a Vector. Since the vectors were refactored into lists, this check will fail and the result of toString() on the list object will be stored in the JSONObject (obviously, not correct). This is one reason reflection shouldn't be used like this.

I will verify and review further, but I'm guessing this pull request should be rejected until the JsonRPCMarshaller class is refactored as well.

[anildahiya]

Updated the JSONMarshaller based on Mike suggestion.

[justinjdickow]

👍

[mikeburke106]

Merged in commit 43d5fd5