You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The SdlProtocolBase sets its major protocol version based on the header of the first packet it receives from core. However in the case where the major version is > 5, the SdlProtocolBase was incorrectly attempting to set the minor version as well.
Reproduction Steps
SdlProtocolBase's _setVersion method uses 5.1.0 but it should only use major versions.
Expected Behavior
The protocol version should be set to v5.0.0.
Test Case, Sample Code, and / or Example App
Add a console.log to check the protocol version in the SdlProtocolBase's _handlePacketReceived method:
Bug Report
The SdlProtocolBase sets its major protocol version based on the header of the first packet it receives from core. However in the case where the major version is
> 5
, the SdlProtocolBase was incorrectly attempting to set the minor version as well.Reproduction Steps
_setVersion
method uses5.1.0
but it should only use major versions.Expected Behavior
The protocol version should be set to v5.0.0.
Test Case, Sample Code, and / or Example App
_handlePacketReceived
method:The text was updated successfully, but these errors were encountered: