Closed
Description
Bug Report
The SdlProtocolBase sets its major protocol version based on the header of the first packet it receives from core. However in the case where the major version is > 5
, the SdlProtocolBase was incorrectly attempting to set the minor version as well.
Reproduction Steps
- SdlProtocolBase's
_setVersion
method uses5.1.0
but it should only use major versions.
Expected Behavior
The protocol version should be set to v5.0.0.
Test Case, Sample Code, and / or Example App
- Add a console.log to check the protocol version in the SdlProtocolBase's
_handlePacketReceived
method:
if (this._protocolVersion === null || this._protocolVersion.getMajor() === 1) {
this._setVersion(sdlPacket.getVersion());
console.log(this._protocolVersion);
}
- The protocol version will be logged when the first packet is received from core.