Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new API to SetMediaClockTimer #356

Merged
merged 4 commits into from
Jan 27, 2021

Conversation

crokita
Copy link
Contributor

@crokita crokita commented Dec 4, 2020

Fixes #346

This PR is ready for review. The equivalent RPC spec PR should be approved before this PR should be merged: smartdevicelink/rpc_spec#292

Risk

This PR makes minor API changes.

Summary

Updates SetMediaClockTimer to include backSeekIndicator and forwardSeekIndicator.

Copy link
Contributor

@renonick87 renonick87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is missing the SeekStreamingIndicator and SeekIndicatorType RPC files.

Copy link
Contributor

@renonick87 renonick87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above regarding missing files.

@crokita
Copy link
Contributor Author

crokita commented Jan 20, 2021

Added missing files

@crokita crokita merged commit 16fab63 into develop Jan 27, 2021
@crokita crokita deleted the feature/0198-media-skip-indicators branch March 26, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SDL 0198] - Media Skip Indicators
2 participants