Feature/choice set manager #371
Conversation
…avascript_suite into feature/choice-set-manager
lib/js/src/manager/screen/choiceset/_CheckChoiceVrOptionalOperation.js
Outdated
Show resolved
Hide resolved
lib/js/src/manager/screen/choiceset/_PresentKeyboardOperation.js
Outdated
Show resolved
Hide resolved
Co-authored-by: renonick87 <nick@livioradio.com>
…devicelink/sdl_javascript_suite into feature/choice-set-manager
…at/sdl_javascript_suite into feature/choice-set-manager" This reverts commit 4c2ee61, reversing changes made to e692b28.
|
PR updated. I didn't include unrelated linter fixes in this PR: that can be done in a separate PR. Also note:
|
tests/managers/index.js
Outdated
| @@ -32,10 +40,19 @@ describe('ManagerTests', function () { | |||
| voiceCommandUpdateOperationTests(appClient); | |||
There was a problem hiding this comment.
Something with the most recent update is causing failures in the voiceCommandManagerTests and voiceCommandUpdateOperationTests for me. I've tested this with manticore across multiple browsers. Everything passes if these tests are moved above the textAndGraphicManagerTests and run first though.
There was a problem hiding this comment.
That's annoying. I have moved those tests and got the same results now.
…script_suite into feature/choice-set-manager
|
Updated. See comments in response to feedback |
There was a problem hiding this comment.
Since this PR contains updates from #357, merging the ChoiceSetManager will have to wait until after that PR is merged first.
|
Updates from #357 have been reverted from this PR. |
|
Squashing to avoid accidentally clearing out this PR: #357 |
jordynmackool
added
proposal
Partially fixes #123
Risk
This PR makes minor API changes.
Testing Plan
Unit Tests
Unit tests added that match the tests added in the Java Suite library for the choice set related classes
Summary
Adds the choice set manager which feature matches the Java Suite library for all the screen manager APIs related to the choice set manager.
Note that presentSearchableChoiceSet would not be supported in the latest develop Generic HMI, and that OnKeyboardInput messages haven't been received.