Skip to content

Fix SdlProtocolBase setting wrong protocol version #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 2, 2021
Merged

Fix SdlProtocolBase setting wrong protocol version #388

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0614b27
Fix SdlProtocolBase setting wrong protocol version
renonick87 Feb 24, 2021
286047a
remove console log
renonick87 Feb 26, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions lib/js/src/protocol/_SdlProtocolBase.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,27 +216,27 @@ class _SdlProtocolBase {
*/
_setVersion (version) {
if (version > 5) {
this._protocolVersion = new Version('5.1.0'); // protect for future, proxy only supports v5 or lower
this._protocolVersion = new Version(5, 0, 0); // protect for future, proxy only supports v5 or lower
this.headerSize = this.constructor.V2_HEADER_SIZE;
this._mtus[_ServiceType.RPC] = this.constructor.V3_V4_MTU_SIZE;
} else if (version === 5) {
this._protocolVersion = new Version('5.0.0');
this._protocolVersion = new Version(5, 0, 0);
this.headerSize = this.constructor.V2_HEADER_SIZE;
this._mtus[_ServiceType.RPC] = this.constructor.V3_V4_MTU_SIZE;
} else if (version === 4) {
this._protocolVersion = new Version('4.0.0');
this._protocolVersion = new Version(4, 0, 0);
this.headerSize = this.constructor.V2_HEADER_SIZE;
this._mtus[_ServiceType.RPC] = this.constructor.V3_V4_MTU_SIZE; // versions 4 supports 128k MTU
} else if (version === 3) {
this._protocolVersion = new Version('3.0.0');
this._protocolVersion = new Version(3, 0, 0);
this.headerSize = this.constructor.V2_HEADER_SIZE;
this._mtus[_ServiceType.RPC] = this.constructor.V3_V4_MTU_SIZE; // versions 3 supports 128k MTU
} else if (version === 2) {
this._protocolVersion = new Version('2.0.0');
this._protocolVersion = new Version(2, 0, 0);
this.headerSize = this.constructor.V2_HEADER_SIZE;
this._mtus[_ServiceType.RPC] = this.constructor.V1_V2_MTU_SIZE - this.headerSize;
} else if (version === 1) {
this._protocolVersion = new Version('1.0.0');
this._protocolVersion = new Version(1, 0, 0);
this.headerSize = this.constructor.V1_HEADER_SIZE;
this._mtus[_ServiceType.RPC] = this.constructor.V1_V2_MTU_SIZE - this.headerSize;
}
Expand Down