Feature/add crc to files #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renonick87
reviewed
Mar 4, 2021
renonick87
requested changes
Mar 4, 2021
renonick87
approved these changes
Mar 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #392
Risk
This PR makes no API changes.
Testing Plan
Unit Tests
Add checks for setting the crc parameter for the file manager PutFile RPCs
Summary
The file manager will now set the CRC parameter automatically of SdlFile data structures when attempting to upload files, generating a checksum for bulk file data. Updated the SdlFile descriptions for file data to use Uint8Array instead of String.
Check the tests added for how to test the new functionality.