Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix positioning of return statement in PermissionManager #404

Merged
merged 1 commit into from
Mar 23, 2021
Merged

Fix positioning of return statement in PermissionManager #404

merged 1 commit into from
Mar 23, 2021

Conversation

crokita
Copy link
Contributor

@crokita crokita commented Mar 22, 2021

Fixes #403

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have verified that this PR passes lint validation
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Core Tests

Tested with 7.1.0 RC

Summary

Fixes when the permission manager's _notifyListeners method returns so that all filters are checked.

@crokita crokita changed the base branch from develop to release/1.3.0_RC March 22, 2021 17:21
@crokita crokita merged commit 8978435 into release/1.3.0_RC Mar 23, 2021
@jordynmackool jordynmackool mentioned this pull request Mar 23, 2021
Closed
@crokita crokita deleted the bugfix/permission-filter-early-return branch March 26, 2021 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renonick87 renonick87 renonick87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PermissionManager with early return in _notifyListeners
2 participants
@crokita @renonick87