ScreenManager Overlapping Button IDs #407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ub-managers when generating button ids
crokita
approved these changes
Mar 23, 2021
Contributor
Author
|
There was an issue where the temporary set of button IDs was copying the address to the original set of button IDs so any updates to the temporary list would also reach the manager's list. I've updated the PR to clone the list to avoid this. |
crokita
approved these changes
Mar 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #405
Risk
This PR makes minor API changes.
Testing Plan
Summary
This PR fixes the issue that would cause the ScreenManager's sub-managers to generate overlapping button IDs that trigger the same button listeners. The AlertManager will now consider the SoftButtonManager's button IDs and vice versa.
CLA