Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Perform null checks for choice set selection listener in manager #412

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Perform null checks for choice set selection listener in manager #412

merged 1 commit into from
Mar 25, 2021

Conversation

crokita
Copy link
Contributor

@crokita crokita commented Mar 23, 2021

Fixes #411

Risk

This PR makes no API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have verified that this PR passes lint validation
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Core Tests

Tested with RC 7.1.0

Summary

Adds a null check to the choicesetmanager's _pendingPresentationSet getChoiceSetSelectionListener method before invoking it.

@crokita crokita merged commit 3724313 into release/1.3.0_RC Mar 25, 2021
@crokita crokita deleted the bugfix/choicesetmanager-choice-keyboard-error branch March 26, 2021 13:51
@jordynmackool jordynmackool mentioned this pull request Apr 14, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@renonick87 renonick87 renonick87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crokita @renonick87