Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sending an empty voice command array should delete all current voice commands #441

Merged
merged 2 commits into from
May 25, 2021
Merged

Sending an empty voice command array should delete all current voice commands #441

merged 2 commits into from
May 25, 2021

Conversation

renonick87
Copy link
Contributor

Fixes #440

Risk

This PR makes minor API changes.

Testing Plan

  • I have verified that I have not introduced new warnings in this PR (or explain why below)
  • I have verified that this PR passes lint validation
  • I have run the unit tests with this PR
  • I have tested this PR against Core and verified behavior (if applicable, if not applicable, explain why below).

Changelog

Bug Fixes
  • Setting an empty voice command array through the screen manager no longer fails and will delete all current voice commands. There are also new unit tests added to confirm the new functionality behaves as expected.

CLA

@renonick87 renonick87 merged commit 7aac493 into develop May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crokita crokita crokita approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setting an empty voice command array should clear the list of voice commands
2 participants
@renonick87 @crokita